Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azservicebus] Adding authorization and subscription rule support #17616

Merged
merged 18 commits into from
Apr 28, 2022

Conversation

richardpark-msft
Copy link
Member

@richardpark-msft richardpark-msft commented Apr 16, 2022

Adding in support for:

  • Getting/updating AuthorizationRules for topics and queues
  • CRUD for working with Subscription rules.

Fixes #16045

* Getting/updating AuthorizationRules for topics and queues
* CRUD for working with Subscription rules.
@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Apr 19, 2022

Does this include the fix for Azure/azure-service-bus-go#204? I think the answer is yes but looking for an ack.

@richardpark-msft
Copy link
Member Author

Does this include the fix for Azure/azure-service-bus-go#204? I think the answer is yes but looking for an ack.

It does, we deserialize the "map[string]interface{}" by hand, since it can't be done automatically. (ie: KeyValueOfstringanyType).

@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit with the unknown types test.

… a replacement of the entityManager in tests only.
@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft richardpark-msft enabled auto-merge (squash) April 28, 2022 19:53
@richardpark-msft richardpark-msft merged commit 1efb698 into Azure:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[azservicebus] AdminClient - Rule management functions
2 participants