Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary setting to empty string #17672

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

jhendrixMSFT
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it was there is that at a time, codegen was generating pagers in old format, and this code was borrowed from keyvault. Now that the new pattern is applied everywhere, it makes sense for all pagers to look the same. I.e. there wasn't any special meaning behind this condition, other that doing what we were doing in other places.

Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jhendrixMSFT jhendrixMSFT merged commit 1534fb0 into Azure:main Apr 20, 2022
@jhendrixMSFT jhendrixMSFT deleted the azappconfig_cleanup branch April 20, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants