Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define log constants in the log package #17730

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Define log constants in the log package #17730

merged 1 commit into from
Apr 27, 2022

Conversation

jhendrixMSFT
Copy link
Member

The constants in the internal package are going away.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@jhendrixMSFT
Define log constants in the log package
54e331f 
The constants in the internal package are going away.
@jhendrixMSFT
Copy link
Member Author

Fixes #17450

richardpark-msft
richardpark-msft approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jhendrixMSFT jhendrixMSFT merged commit 74afd9c into Azure:main Apr 27, 2022
@jhendrixMSFT jhendrixMSFT deleted the azcore_log branch April 27, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@richardpark-msft richardpark-msft richardpark-msft approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@seankane-msft seankane-msft Awaiting requested review from seankane-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhendrixMSFT @chlowell @richardpark-msft