Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete JSON tags on Key Vault convenience models #18320

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Jun 6, 2022

These are unnecessary because convenience models never go on the wire, and we don't have a feature like cross-language interop that requires a particular JSON representation.

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 6, 2022
@chlowell chlowell requested a review from richardpark-msft June 6, 2022 18:30
@chlowell chlowell requested a review from jhendrixMSFT as a code owner June 6, 2022 18:30
@chlowell chlowell merged commit 2e712cf into Azure:main Jun 7, 2022
@chlowell chlowell deleted the remove-json-tags branch June 7, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants