Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated track1 xxxapi #19766

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Deprecated track1 xxxapi #19766

merged 4 commits into from
Jan 10, 2023

Conversation

Alancere
Copy link
Contributor

@Alancere Alancere commented Jan 6, 2023

@Alancere Alancere requested a review from tadelesh January 6, 2023 09:40
xboxeer
xboxeer approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@xboxeer xboxeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lirenhe
lirenhe approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Randomly pick up and check some of items.
LGTM

@Alancere Alancere merged commit 002819b into Azure:legacy Jan 10, 2023
@Alancere Alancere linked an issue Jan 11, 2023 that may be closed by this pull request
Add enough deprecation message to legacy packages #19731
Closed
@dany74q dany74q mentioned this pull request Jan 16, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang left review comments

@lirenhe lirenhe lirenhe approved these changes

@xboxeer xboxeer xboxeer approved these changes

@tadelesh tadelesh tadelesh approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add enough deprecation message to legacy packages
5 participants
@Alancere @tadelesh @xboxeer @lirenhe @ArcturusZhang