[azservicebus] Validate that credits are within limits (not over or under) #19992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 9, 2023 16:15
- <= 0 is bad since it can hang and we never intend to subtract credit. - Don't allow asking for more than the actual credit ceiling of the link, which is set, statically, when the link is created.
…hims of the go-scheduler and the speed of our test.
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
February 9, 2023 16:45
Also, sanity check that we do pass in the proper Credit value.
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
February 9, 2023 19:09
…rable) to be able to get logs multiple times, siphoning off whatever is in the channel at that point. This also eliminates another silly problem I have sometimes where the channel is closed early (because I extract logs) but the receiver or sender is still doing some background work which generates log information.
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jhendrixMSFT
approved these changes
Feb 14, 2023
|
Once we get the underlying issue in |
Yeah, infinite credits and infinite sinks will be a nice touch. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issues where we could over-request credit (#19965) or allow for negative/zero credits (#19743), both of which could cause issues with go-amqp..
Fixes #19965
Fixes #19743