Update CODEOWNERS paths: fix invalid paths
#19994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240 Related PRs: - Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584 - Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
requested review from
RickWinter and
jhendrixMSFT
as code owners
benbp
reviewed
Feb 13, 2023
benbp
approved these changes
Feb 13, 2023
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of ongoing work of enabling wildcard support for
CODEOWNERS:and enabling stricter validation:
this PR:
/**/tests.ymland/**/ci.yml, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supportingCODEOWNERSmatcher, per: Enable the new, regex-based, wildcard-supporting CODEOWNERS matcher azure-sdk-tools#5088 (comment)Once this PR is merged, I will enable the new
CODEOWNERSmatcher, similar to how it was done fornetrepo by these two PRs:azure-sdk-for-netrepo azure-sdk-tools#5241NotificationConfigurationpackage from20230119.1to20230127.4azure-sdk-tools#5240