Fixed issue in challenge policy to prevent multiple requests from being sent in the happy case. #20554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
requested review from
siminsavani-msft,
souravgupta-msft,
tasherif-msft,
jhendrixMSFT and
vibhansa-msft
as code owners
ghost
added
the
gapra-msft
commented
Apr 4, 2023
gapra-msft
commented
Apr 4, 2023
souravgupta-msft
approved these changes
Apr 5, 2023
vibhansa-msft
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Changelog entry is not necessary since this hasn't been released yet
I re-ran the test in pageblob/managed_disk_test.go manually and it passed.