Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default audience value for ACR #20838

Merged
merged 2 commits into from
May 17, 2023
Merged

change default audience value for ACR #20838

merged 2 commits into from
May 17, 2023

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented May 11, 2023 •
edited
Loading

Also remove live test for China cloud as it always has network issue.

Resolve: #20835

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@tadelesh tadelesh merged commit c5a5371 into Azure:main May 17, 2023
@tadelesh tadelesh deleted the change_default_audience branch November 27, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the new default value if there is no cloud configuration put in the client options
2 participants
@tadelesh @jhendrixMSFT