Enable custom RetryOptions to be specified per API call #7343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added WithRetryOptions() that adds a custom RetryOptions to the provided context, allowing custom settings per API call. Remove 429 from the list of default HTTP status codes for retry. Change StatusCodesForRetry to a slice so consumers can append to it.
Cleaned up some comments specific to storage.
JeffreyRichter
approved these changes
Feb 15, 2020
sdk/azcore/policy_retry.go
Outdated
|
|
||
| // ContextWithRetryOptions adds the specified RetryOptions to the parent context. | ||
| // Use this to specify custom RetryOptions at the API-call level. | ||
| func ContextWithRetryOptions(parent context.Context, options RetryOptions) context.Context { |
There was a problem hiding this comment.
Rename to WithRetryOptions (no Context) to match WithValue, WithDeadline, etc.
There was a problem hiding this comment.
Originally I had it without the Context prefix however it seemed a big vague (i.e. azcore.WithRetryOptions()). Your examples are functions in the context package so you get names like context.WithValue() which is clear. I can remove the Context prefix if we think having the parent context being the first parameter is clear enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added WithRetryOptions() that adds a custom RetryOptions to the provided
context, allowing custom settings per API call.
Remove 429 from the list of default HTTP status codes for retry.
Change StatusCodesForRetry to a slice so consumers can append to it.