-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue: createMessage should throw for null message instead of submitting #121
Comments
from @jcookems The design we've been using for the APIs is to: If bad data will cause the SDK code to error in other helper methods, which results in a confusinng client error (see #42), then validate those parameters. |
Looks good. Unit tests are sufficient. |
implementation for multiple property filter
Fixing bug in getShareQuota and removing unnecessary code.
Dev estimate: 1
Test estimate: 1
Moved from private repository.
This code:
QueueContract service = createService();
service.createMessage("foo", null);
submits this XML to the server:
But the server doesn't like that:
InvalidXmlDocument: XML specified is not syntactically valid.
LineNumber: 0
LinePosition: 0
Would be nice to throw immediately instead of requiring the user to parse through the ServiceException themselves.
Similar issue for updateMessage when PopReciept is null: popreceiptquery parameter is required
The text was updated successfully, but these errors were encountered: