-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]the return value of customized convert should follow Spring secuity standard #20388
Comments
@backwind1233, You are right. |
@ZhuXiaoBing-cn I suggest don't change the OAuth2AuthenticatedPrincipal's getName method, we can replace BearerTokenAuthentication with our own class |
@backwind1233 @ZhuXiaoBing-cn will this change in #20340 also affect the Prinicipal we're talking in this thread? |
Okay, even though they're all implementing the |
Review request for Microsoft.ContainerService to add version 2022-08-02-preview (Azure#20487) * Adds base for updating Microsoft.ContainerService from version preview/2022-07-02-preview to version 2022-08-02-preview * Updates readme * Updates API version in new specs and examples * sync changes from PR#19592 & PR#20145 (Azure#20402) * update readme & remove fleets (Azure#20388) * AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT (Azure#20407) * AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT * Change disableOutboundNAT to disableOutboundNat because of ARM format; Improve description. * Improve description * Added guardrails profile to specs (Azure#20171) * added guardrails profile to specs * linter fix * added x-ms-enum * added guardrails definitions for versions route * linter fix, added custom word * fix * typo fix * fix for example * added object type * added object type * removed data field * changed descriptions * * * add "Mariner" for AKS os sku (Azure#20420) * add KubeProxyConfig to AKS NetworkProfile (Azure#20446) * add KubeProxyConfig to AKS NetworkProfile * remove extra comma, type: integer for *Seconds * add custom words * prettier * follow camel case ARM guidance * 2nd camel case standard * feat: add rest api spec for ip-based lb (Azure#20392) * fix LroLocationHeader (Azure#20491) * fix ProvisioningStateValidation (Azure#20490) * Removed guardrailsVersions route, added guardrails profice to MC properties (Azure#20625) * removed guardrails-versions route, added guardrails profice to MC properties * removed unsued file for guardrails versions, removed unused custom word Co-authored-by: Shiqian Tao <62196586+ShiqianTao@users.noreply.github.com> Co-authored-by: rsamigullin <89222124+rsamigullin@users.noreply.github.com> Co-authored-by: Ace Eldeib <aleldeib@microsoft.com> Co-authored-by: Matt Stam <mattstam@live.com> Co-authored-by: Qi Ni <pomelonicky@gmail.com>
Describe the bug
by default, a bearer token in request will be convert into an AbstractAuthenticationToken object through spring security framwork, and the AbstractAuthenticationToken object's getName will get subject claim in the bearer token.
but our customized AADB2CJwtBearerTokenAuthenticationConverter’s convert method does not follow the standard, which will cause some unexpected problem.
Exception or Stack Trace
To Reproduce
Code Snippet
Expected behavior
Screenshots
Setup (please complete the following information):
Additional context
Information Checklist
The text was updated successfully, but these errors were encountered: