Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some samples have invalid product slugs #20685

Closed
heaths opened this issue Apr 15, 2021 · 3 comments · Fixed by #20679
Closed

Some samples have invalid product slugs #20685

heaths opened this issue Apr 15, 2021 · 3 comments · Fixed by #20679
Labels
EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Apr 15, 2021

In order for samples to show up in the Samples Browser, they need to have valid product slugs. Using the new script added by PR #20676, I found the following invalid product slugs in files:

InvalidProducts Path
{azure-monitor-opentelemetry-exporter} .\sdk\monitor\azure-monitor-opentelemetry-exporter\src\samples\README.md
{azure-data-schemaregistry} .\sdk\schemaregistry\azure-data-schemaregistry\src\samples\README.md
{azure-data-schemaregistry-avro} .\sdk\schemaregistry\azure-data-schemaregistry-avro\src\samples\README.md
{azure-search-documents} .\sdk\search\azure-search-documents\src\samples\README.md
{java} .\sdk\spring\azure-spring-boot-samples\azure-spring-boot-sample-active-directory-resource-server-by-filter\README.md
{azure-file} .\sdk\storage\azure-storage-file-share\src\samples\README.md
{azure-tables} .\sdk\tables\azure-data-tables\src\samples\README.md

Note: the validation template is not hooked up current. See #20684.

@heaths heaths added the EngSys This issue is impacting the engineering system. label Apr 15, 2021
@heaths
Copy link
Member Author

heaths commented Apr 15, 2021

I suggest:

Old New
azure-monitor-opentelemetry-exporter azure-monitor
azure-data-schemaregistry azure-event-hubs
azure-data-schemaregistry-avro azure-event-hubs
azure-search-documents azure-cognitive-search
java (none - not a product slug)
azure-file azure-storage (maybe azure-disk-storage? @tg-msft?)
azure-tables azure-table-storage

@YijunXieMS
Copy link
Contributor

for azure-file, I see azure-files. Is this the correct one?

@heaths
Copy link
Member Author

heaths commented Apr 15, 2021

That's a good question. The display name simply says "Files". Unfortunately, under https://docs.microsoft.com/en-us/samples/browse/?expanded=azure&filter-products=Files I don't see just "Files". We could add it and see if we get feedback otherwise, but seems no one else is using it.

@tg-msft any idea if simply "Files" could fit anything else besides Storage in Azure? Nothing comes to mind for me.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants