Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up validate-samples.yml #20684

Closed
heaths opened this issue Apr 15, 2021 · 1 comment · Fixed by #20693
Closed

Hook up validate-samples.yml #20684

heaths opened this issue Apr 15, 2021 · 1 comment · Fixed by #20693
Labels
EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Apr 15, 2021

Based on #20676 (comment) I was unable to hook up the validate-samples.yml pipeline template. Once the script is fixed, it should be added like so:

diff --git a/eng/pipelines/templates/jobs/ci.yml b/eng/pipelines/templates/jobs/ci.yml
index 443ca9fc64..d1b139cd20 100644
--- a/eng/pipelines/templates/jobs/ci.yml
+++ b/eng/pipelines/templates/jobs/ci.yml
@@ -169,6 +169,10 @@ jobs:
             Directory: sdk/${{ parameters.ServiceDirectory }}
           CheckLinkGuidance: $true

+      - template: /eng/common/pipelines/templates/steps/verify-samples.yml
+        parameters:
+          ServiceDirectory: ${{ parameters.ServiceDirectory }}
+
       # Use BasePathLength of 38 instead of the default 49 as some GA'd files fail when the number is higher.
       - template: /eng/common/pipelines/templates/steps/verify-path-length.yml
         parameters:
@heaths heaths added the EngSys This issue is impacting the engineering system. label Apr 15, 2021
@heaths heaths mentioned this issue Apr 15, 2021
Closed
heaths added a commit to heaths/azure-sdk-tools that referenced this issue Apr 15, 2021
@heaths
Handle empty files in Test-SampleMetadata
38a1858 
Relates to Azure/azure-sdk-for-java#20684
@heaths heaths mentioned this issue Apr 15, 2021
Merged
azure-sdk pushed a commit to Azure/azure-sdk-for-android that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
cc8e2a1 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-c that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
e5fe7f2 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-cpp that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
3a687a6 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-go that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
a6672b3 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-ios that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
138a930 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
26b8644 
Relates to #20684
azure-sdk pushed a commit to Azure/azure-sdk-for-js that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
cc28bd0 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-android that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
5adea20 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-c that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
ef505a3 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-cpp that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
e475633 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-go that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
1a9aade 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-ios that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
6b21d22 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
dec7176 
Relates to #20684
azure-sdk pushed a commit to Azure/azure-sdk-for-js that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
466ac87 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-python that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
306a703 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-android that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
8753a25 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-c that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
326f102 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-cpp that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
6b96cb7 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-go that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
c7e5f52 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-ios that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
4a25c15 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
d8b1be6 
Relates to #20684
azure-sdk pushed a commit to Azure/azure-sdk-for-js that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
31a0191 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-python that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
cf94d39 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-android that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
eda82a3 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-c that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
332caea 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-cpp that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
5c3136e 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-go that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
136b451 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-ios that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
87a4b2e 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
b2c5560 
Relates to #20684
azure-sdk pushed a commit to Azure/azure-sdk-for-js that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
e725fca 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-net that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
7380295 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk pushed a commit to Azure/azure-sdk-for-python that referenced this issue Apr 15, 2021
@heaths @azure-sdk
Handle empty files in Test-SampleMetadata
ed33287 
Relates to Azure/azure-sdk-for-java#20684
azure-sdk added a commit to Azure/azure-sdk-for-android that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#742)
eb751fa 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-c that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#1696)
3ce9c64 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-cpp that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#2123)
6b50feb 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-go that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#14535)
e892924 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-ios that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#819)
fb48099 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#14891)
510acb8 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-net that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#20422)
9bc5c82 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-python that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#18064)
f394ae8 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

* Remove invalid 'telemetry' product slug

Relates to #17991

* Disable verify-samples template

Opened #18066 to track re-enabling it.

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk added a commit that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#20693)
69f0383 
* Handle empty files in Test-SampleMetadata

Relates to #20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

* Use verify-samples template

Co-authored-by: Heath Stewart <heaths@microsoft.com>
ghost pushed a commit to Azure/azure-sdk-tools that referenced this issue Apr 15, 2021
@heaths
Handle empty files in Test-SampleMetadata (#1559)
15c92f7 
Relates to Azure/azure-sdk-for-java#20684
@heaths
Copy link
Member Author

heaths commented Apr 15, 2021

Resolved by 69f0383

@heaths heaths closed this as completed Apr 15, 2021
@heaths heaths linked a pull request Apr 15, 2021 that will close this issue
Sync eng/common directory with azure-sdk-tools for PR 1559 #20693
Merged
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this issue Apr 26, 2021
@azure-sdk @heaths @vindicatesociety
Sync eng/common directory with azure-sdk-tools for PR 1559 (Azure#14891)
5f9bcfe 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
benbp pushed a commit that referenced this issue Apr 28, 2021
@azure-sdk @heaths @benbp
Sync eng/common directory with azure-sdk-tools for PR 1559 (#20693)
f1a4e6c 
* Handle empty files in Test-SampleMetadata

Relates to #20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

* Use verify-samples template

Co-authored-by: Heath Stewart <heaths@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync eng/common directory with azure-sdk-tools for PR 1559 Azure/azure-sdk-for-java
1 participant
@heaths