-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] The Spring Key Vault integration (spring-cloud-azure-starter-keyvault-secrets
) does not work with local test doubles
#36561
Comments
Hi @nagyesta , thanks for reaching out. |
- Adds disableChallengeResourceVerification property to properties objects - Includes new property in mapping methods - Configures SecretClient in Factory when disableChallengeResourceVerification is set - Configures CertificateClient in Factory when disableChallengeResourceVerification is set - Updates/adds new tests - Updates Changelog Resolves Azure#36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com>
… - Code review fixes #1 - Renames disableChallengeResourceVerification to challengeResourceVerificationEnabled - Adds additional JavaDoc Resolves Azure#36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com>
… - Code review fixes Azure#3 - Simplifies factory method logic as per code review recommendation Resolves Azure#36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com>
…property of AKV SecretClient (#36603) * Allows configuration of disableChallengeResourceVerification property - Adds disableChallengeResourceVerification property to properties objects - Includes new property in mapping methods - Configures SecretClient in Factory when disableChallengeResourceVerification is set - Configures CertificateClient in Factory when disableChallengeResourceVerification is set - Updates/adds new tests - Updates Changelog Resolves #36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com> * Allows configuration of disableChallengeResourceVerification property - Code review fixes #1 - Renames disableChallengeResourceVerification to challengeResourceVerificationEnabled - Adds additional JavaDoc Resolves #36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com> * Allows configuration of disableChallengeResourceVerification property - Fix a missed JavaDoc Signed-off-by: Esta Nagy <nagyesta@gmail.com> * Improve the configuration properties javadoc, and complete the additional-spring-configuration-metadata.json * Allows configuration of disableChallengeResourceVerification property - Code review fixes #3 - Simplifies factory method logic as per code review recommendation Resolves #36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com> --------- Signed-off-by: Esta Nagy <nagyesta@gmail.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Xiaolu Dai <xiada@microsoft.com>
close it for fixed |
Describe the bug
The Spring Key Vault integration (
spring-cloud-azure-starter-keyvault-secrets
) does not work with local test doubles because thedisableChallengeResourceVerification
option is not configurable.Exception or Stack Trace
Add the exception log and stack trace if available
To Reproduce
Steps to reproduce the behavior:
Please check the
failing
branch of the example project I have created here: https://github.com/nagyesta/spring-boot-local-key-vault-demo/tree/failingCode Snippet
com.azure.spring.cloud.autoconfigure.implementation.keyvault.secrets.properties.AzureKeyVaultPropertySourceProperties
does not have adisableChallengeResourceVerification
field (and the related getter-setter).Therefore, the
com.azure.security.keyvault.secrets.SecretClientBuilder#buildInnerClient
method cannot set it as true in this line:Expected behavior
The client configuration should allow disableChallengeResourceVerification to be freely configured for tests.
Screenshots
N/A
Setup (please complete the following information):
Additional context
Related to #29651
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
The text was updated successfully, but these errors were encountered: