Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source access conditions not honored by BlobRestProxy.copyBlob #85

Closed
jcookems opened this issue May 22, 2012 · 2 comments
Closed

Source access conditions not honored by BlobRestProxy.copyBlob #85

jcookems opened this issue May 22, 2012 · 2 comments

Comments

@jcookems
Copy link
Contributor

Regardless of what source access conditions are provided in the options of CopyBlob, the calls succeed. This is because of an issue in PipelineHelpers.addOptionalSourceAccessContitionHeader, reproduced here:

            switch (accessCondition.getHeader()) {
                case IF_MATCH:
                    headerName = "x-ms-source-if-match";
                case IF_UNMODIFIED_SINCE:
                    headerName = "x-ms-source-if-unmodified-since";
                case IF_MODIFIED_SINCE:
                    headerName = "x-ms-source-if-modified-since";
                case IF_NONE_MATCH:
                    headerName = "x-ms-source-if-none-match";
                default:
                    headerName = "";
            }

The problem is that in Java, one case cascades into the next, so regardless of the value of the Header property, the headerName is always the empty string.

The fix is to add a break; statement at the end of each case block.

@ghost
Copy link

ghost commented Jul 11, 2012

Pending code review #104

@ghost ghost assigned gcheng Jul 13, 2012
@gcheng
Copy link

gcheng commented Jul 27, 2012

gosh, the whole namespace doesn't have unit test!

@gcheng gcheng closed this as completed Aug 7, 2012
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this issue Jan 18, 2013
Add support for continuation uri (skip and top). fixes Azure#4
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this issue Jan 18, 2013
DCR of action to expose two types of action API
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this issue Apr 5, 2017
Add support for continuation uri (skip and top). fixes #4
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this issue Apr 5, 2017
DCR of action to expose two types of action API
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue Mar 4, 2019
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this issue Apr 23, 2019
* Fixing javadoc generation errors

* Adding dependency to use SLF4J logging instead of java util logging.

* More SLF4J migration

* Changed all java util logging statements to slf4j.

* Checking in the POM that goes with the release to maven reposisory.

* Removed unused imports

* Instrumented all code with SLF4J logging.

* Fixing some log statements

* Moving request-response link creation to message factory so we don't create multiple links to the same entity.

* Updaing third party notice to include SLF4J license.

* Updating distributed POM

* Renaming setContent method to setBody.

* Fixing a typo in log statement.

* Handling the special case of 0 timeout for receives. If there are no prefetched messages, receive call returns immediately with already prefetched messages.

* Correcting a log statement

* Added javadoc comments for rules package.

* Adding javadoc comments. Work in progress.

* More javadoc comments added.

* Fixing a minor bug in sender and receiver creation. Closes the messaging factory if sender or receiver creation fails.

* Fixing the issue of not renewing CBS tokens. Also a concurrency fix.

* Fixing a bug in session receiver to not repeatedly attempt accepting the same session on lock lost.

* Added some java docs.. And changed default prefetch count, based on receive mode.

* Fixing a thread unending wait bug in request-response link.
navalev pushed a commit to navalev/azure-sdk-for-java that referenced this issue Dec 24, 2019
* Change order of lat/long

* Record tests

* Provide a public API method for creating GeoPoint with custom coordinate system.

Co-Authored-By: Noel <noelbundick@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants