Misc networking fit and finish + annotations #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
September 16, 2016 07:17
…y in how resources across different services reference subnets
- no need for primarySubnetId() since it can be retrieved from primaryIpConfiguration() - renaming primaryNetwork() as getPrimaryNetwork() to be consistent with the naming of methods that make a separate call to Azure, rather than directly retrieve a prooperty of the object. - removing the caching logic for the primary network as it seems unnecessary. - refactoring NicIpConfiguration to use the shared HasSubnet interface for better API consistency enforcement
- removing primary-related accessors for PIP and Network from NIC because they are avaialable easily enough via primaryIpConfiguration() - renaming VirtualMachine#primaryPublicIpAddress() as getPrimaryPublicIpAddress() to be consistent with other methods that actually call Azure, rather than simply return a direct property (also removing the caching logic as it seems a bit unnecessary) - adding VirtualMachine#primaryPublicIpAddressId() as a shortcut
…or better consistency and reuse
… interface for better consistency
|
Can one of the admins verify this patch? |
|
Runtime changes detected. pull request created. CI running: |
|
Runtime changes detected. pull request created. CI running: |
added 3 commits
September 21, 2016 10:19
…dundant ones from nested interfaces
…) and the caching logic altogether as it seems redundant from the user scenario perspective
|
Runtime changes detected. pull request created. CI running: |
added 2 commits
September 21, 2016 11:19
…rted to properties, but should remain methods
|
Runtime changes detected. pull request created. CI running: |
added 2 commits
September 22, 2016 12:32
# Conflicts: # azure-mgmt-compute/src/main/java/com/microsoft/azure/management/compute/VirtualMachineExtension.java
|
Runtime changes detected. pull request created. CI running: |
Merged
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Updating compute unit test to use RestClient
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Misc networking fit and finish + annotations
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Updating compute unit test to use RestClient
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Misc networking fit and finish + annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compat breaks from beta2:
NetworkInterface#primarySubnetId()NicIpConfiguration#subnetId()VirtualMachine#primaryPublicIpAddress()asgetPrimaryPublicIpAddress()NetworkInterface#primaryPublicIpAddress()NetworkIntrerface#primaryNetwork()StorageAccount#refreshKeys()asgetKeys()StorageAccount#keys()