Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding api annotations to graph and keyvault #1091

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

jianghaolu
Copy link
Contributor

No description provided.

@azuresdkci
Copy link
Contributor

Runtime changes detected. pull request created. CI running: Build Status

Copy link

@martinsawicki martinsawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to change from @LandDefinition(...) to @fluent() at the top level, and remove all other LangDefinition annotationms from nested interfaces. The empty @fluent at the top should be sufficient.

import com.microsoft.azure.management.graphrbac.implementation.ADGroupInner;
import com.microsoft.azure.management.resources.fluentcore.model.Creatable;
import com.microsoft.azure.management.resources.fluentcore.model.Wrapper;

/**
* An immutable client-side representation of an Azure AD group.
*/
@LangDefinition

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we now have a simplified annotations approach: just use @fluent() at the top interface and nothing else is needed. The embedded interfaces will be processed automatically - no need to annotate them (per Alva).
The LangDefinition imports can simply be all removed.

@martinsawicki martinsawicki merged commit d4748b8 into Azure:master Sep 23, 2016
@jianghaolu
Copy link
Contributor Author

Oops? I haven't converted the annotations.

jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
Fixing PagedList and adding unit test for ResourcePagedList
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
i'll deal with the annotation updates as part of my overall scrub
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
Fixing PagedList and adding unit test for ResourcePagedList
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
i'll deal with the annotation updates as part of my overall scrub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants