Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use SNAPSHOT to add SBT compatibility" #1238

Closed
wants to merge 1 commit into from

Conversation

martinsawicki
Copy link

Reverts #1237 --- looks like this change broke the compilation of several projects after I synched with master locally, so reverting till we get to the bottom of this one.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jianghaolu
Copy link
Contributor

#1237 passes CI so the build shouldn't be a problem.

however, there are a few tricks to get SNAPSHOT working locally, especially in IDE. (That's why the reason I started using exact date versions instead of "SNAPSHOT" in the beginning)

If you do a mvn compile -U and it works, then the project has no compilation issues.

@martinsawicki
Copy link
Author

thanks, mvn compile -U, followed by Project Clean fixed the project compilation problems in Eclipse.
So closing the Revert PR.

@jianghaolu jianghaolu deleted the revert-1237-snapshot branch April 5, 2017 20:46
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Mar 21, 2019
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants