Added support for directory and delegation SAS #14531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gapra-msft
commented
Aug 27, 2020
...ge/azure-storage-common/src/main/java/com/azure/storage/common/implementation/Constants.java
Outdated
Show resolved
Hide resolved
gapra-msft
commented
Aug 27, 2020
...zure-storage-common/src/main/java/com/azure/storage/common/sas/CommonSasQueryParameters.java
Outdated
Show resolved
Hide resolved
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
gapra-msft
requested review from
anuchandy,
bsiegel,
chenrujun,
ChenTanyi,
conniey,
danieljurek,
David-Noble-at-work,
hemanttanwar,
jialindai and
jianghaolu
as code owners
gapra-msft
requested review from
amnguye
and removed request for
jialindai,
xseeseesee,
kasobol-msft,
yiliuTo,
xinlian12,
kirankumarkolli,
anuchandy,
bsiegel,
conniey,
danieljurek,
David-Noble-at-work,
hemanttanwar,
jianghaolu,
JonathanGiles,
joshfree,
mbhaskar,
mitchdenny,
weshaggard and
zhoufenqin
amnguye
approved these changes
Sep 4, 2020
| @@ -11,6 +11,7 @@ | |||
| import java.util.Map; | |||
| import java.util.function.Function; | |||
|
|
|||
|
|
|||
| @@ -4,6 +4,7 @@ | |||
| - Added support for the 2019-02-10 service version. | |||
| - Added support to schedule file expiration. | |||
| - Added support to specify Arrow Output Serialization when querying a file. | |||
| - Added support to generate directory SAS and added support to specify additional user ids and correlation ids for user delegation SAS. | |||
There was a problem hiding this comment.
NIT - double space after "..correlation ids for"
| * b. Otherwise, if "SnapshotId" is set, it is a blob snapshot resource. | ||
| * c. Otherwise, if "VersionId" is set, it is a blob version resource. | ||
| * d. Otherwise, it is a blob resource. | ||
| * 3. Reparse permissions depending on what the resource is. If it is an unrecognised resource, do nothing. |
There was a problem hiding this comment.
NIT - unrecognised -> unrecognized
gapra-msft
added a commit
that referenced
this pull request
Oct 1, 2020
* Updated all service versions to STG74 (#14079) * Added code for get file range diff (#14140) * Added code for smb multi channel (#14180) * Added code to allow scheduling file expiry (#14319) * Added support for arrow output serialization (#14431) * Added support to read last access time (#14342) * Added support to lease shares (#14287) * Updated file ranges to getFileRangesDiff (#14839) * Added support for directory and delegation SAS (#14531) * Recursive acl (#14669) * Added missing error code (#14986) * Added tests to ensure support for 4TB file (#15179) Co-authored-by: Gauri Prasad <gapra@microsoft.com> * Storage/file share error code (#15007) * Fixed simple renames and doc issues from 74 (#15297) Co-authored-by: Gauri Prasad <gapra@microsoft.com> * Added back support for container undelete. (#15344) * Regenerated code to address APIView comments (#15341) * Minor changelog formatting issues * Formatting - new lines and unused imports * Fixed public API for file get range diff (#15562) * Modified recursive acl tests to be able to play in live mode (#15815) * Added support for live tests in the STG 74 branch (#15724) * Added code to return batch failures in results for recursive ACL (#15842) * Wrapped continuation token with Exception when recursive acl call is … (#15839) Co-authored-by: Gauri Prasad <gapra@microsoft.com> Co-authored-by: Rick Ley <frley@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #10378