Add setter to configure ClientOptions on processor builder #18148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srnagar
requested review from
conniey,
mssfang and
YijunXieMS
as code owners
ghost
added
the
conniey
approved these changes
Jan 4, 2021
|
@JonathanGiles |
|
Yep - as discussed, just be sure to note that the headers are applicable to the admin client rather than the amqp clients. |
srnagar
requested review from
alzimmermsft,
danieljurek,
JimSuplizio,
mitchdenny and
samvaity
as code owners
YijunXieMS
reviewed
Jan 14, 2021
...aging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventProcessorClientBuilder.java
Show resolved
Hide resolved
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Apr 18, 2022
[Hub Generated] Public private branch 'elastic-san-preview' (Azure#18148) * Initial Check-In to introduce ElasticSan RP * Applied coding styles and fixed the spelling mistake. * Updated with IOPS & MBps properties * Updated swagger file with NetWork Acls * Added "None" to protocol type and updated with other validations. * Removed ElasticSan from VolumeGroup operations * Addressed review comments by adding elasticSanName in each of its operation * Added volumeGroupName Parameters to the operations * Upated array item with "x-ms-identifiers": [] as per Swagger Lint recommendations * Removed unused parameters * Updated with Snapshot endpoints * Updated with missing "type" declarations * Added Snapshot changes and addressed the PR review comments * Fixed Lint differences * Fixed Lint difference * Added Export feature for Snapshot * Updated with Sku level settings * Updated with AdditionalInfo with "x-ms-identifiers": [] * Fixed Lint compilation issue with "x-ms-identifiers": [], * Fixed Prettier issues * Updated the readme* files with the right package and namespaces. * Pointed GO to track2 * Updated readme.go.md with the yaml format * Addressed review comments, updated with ecommon types and added naming restrictions. * Updated with common SystemData * Corrected the missing json structure * Updated 'CreateOrUpdate" with "Create" * Updated the spec with Network ACLs * Removed unnecessary error codes * Regenerated the examples * Removed Snapshot API and addressed PR comments (Azure#18638) * Removed Snapshot API and addressed PR comments * Removed Ruby SDK information (Azure#18662) * Reverted tsconfig.json and removed Ruby related SDK information. * Corrected the indentation for swagger-to-sdk Co-authored-by: Rajesh Kumar Aggani <raaggani@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new setter method on the
EventProcessorClientBuilderto configureClientOptions.Fixes #17595