Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder aggregate-report Steps #18567

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Reorder aggregate-report Steps #18567

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6bcc53
Reorder aggregate-report Steps
alzimmermsft Jan 12, 2021
7a21e1b
Merge branch 'master' into AzEng_UpdateAggregateToRunWhenLinksFail
alzimmermsft Jan 12, 2021
d780a4c
Remove invalid condition from template step
alzimmermsft Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions eng/pipelines/aggregate-reports.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ jobs:
vmImage: 'ubuntu-18.04'
steps:

- template: ../common/pipelines/templates/steps/verify-links.yml
parameters:
Directory: ""
CheckLinkGuidance: $true

# We `install` the code quality reports tooling into our local m2 cache separately from building the Maven project
# reports. This means it is available as part of that, but also so that this is not documented in the project report.
- template: templates/steps/install-reporting-tools.yml
Expand All @@ -44,7 +39,8 @@ jobs:
- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
# ComponentGovernance is currently unable to run on pull requests of public projects. Running on non-PR
# builds should be sufficient.
condition: and(succeededOrFailed(), ne(variables['Build.Reason'], 'PullRequest'))
# Only run if building all libraries succeeded.
condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest'))
displayName: 'Component Detection'

- task: Maven@3
Expand Down Expand Up @@ -98,6 +94,13 @@ jobs:
Copy-Item data.js $(Build.ArtifactStagingDirectory)/staging
displayName: 'Copy reports to artifact staging'

# Run link verification at the end as it will run no matter the pipeline passing or failing.
# If this task fails with an error it shouldn't prevent aggregate reports from being generated.
- template: ../common/pipelines/templates/steps/verify-links.yml
alzimmermsft marked this conversation as resolved.
Show resolved Hide resolved
parameters:
Directory: ""
CheckLinkGuidance: $true

- publish: $(Build.ArtifactStagingDirectory)
condition: succeededOrFailed()
displayName: 'Publish Report Artifacts'
Expand Down