Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme issues for the azure service bus #19551

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Fix readme issues for the azure service bus #19551

merged 3 commits into from
Jul 2, 2021

Conversation

frascu
Copy link
Contributor

@frascu frascu commented Mar 2, 2021

This fixes issue #18807.
If @hemanttanwar has not already fixed, this pull request could be merged.

@ghost ghost added Service Bus customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 2, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

Thank you for your contribution frascu! We will review the pull request and get back to you soon.

@frascu
Copy link
Contributor Author

frascu commented Mar 22, 2021

/azp run java - servicebus - ci

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 19551 in repo Azure/azure-sdk-for-java

@v-xuto
Copy link
Member

v-xuto commented May 27, 2021

@hemanttanwar @conniey - Can you help review this PR?

@joshfree joshfree requested review from ki1729 and removed request for hemanttanwar, conniey and yvgopal June 30, 2021 00:29
@joshfree joshfree added the Client This issue points to a problem in the data-plane of the library. label Jun 30, 2021
@joshfree
Copy link
Member

@ki1729 can you please review this PR as part of resolving #18807

Copy link
Contributor

@ki1729 ki1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ki1729 ki1729 enabled auto-merge (squash) July 1, 2021 17:19
@check-enforcer
Copy link

check-enforcer bot commented Jul 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@ki1729
Copy link
Contributor

ki1729 commented Jul 2, 2021

/azp run java - servicebus - ci

1 similar comment
@mikeharder
Copy link
Member

/azp run java - servicebus - ci

@mikeharder
Copy link
Member

Closing and re-opening to trigger pipelines

@mikeharder mikeharder closed this Jul 2, 2021
auto-merge was automatically disabled July 2, 2021 19:23

Pull request was closed

@mikeharder mikeharder reopened this Jul 2, 2021
@mikeharder
Copy link
Member

/azp where

@mikeharder
Copy link
Member

mikeharder commented Jul 2, 2021

@mikeharder
Copy link
Member

/check-enforcer override

@ki1729 ki1729 merged commit 5edf85b into Azure:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants