Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of DataFactory pipeline #19836

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

valfirst
Copy link
Contributor

The error is:

java.lang.IllegalArgumentException: Body parameter value must not be null. (parameter #10)
    for method PipelinesService.createRun
	at retrofit2.Utils.methodError(Utils.java:52)
	at retrofit2.Utils.methodError(Utils.java:42)
	at retrofit2.Utils.parameterError(Utils.java:61)
	at retrofit2.ParameterHandler$Body.apply(ParameterHandler.java:408)
	at retrofit2.RequestFactory.create(RequestFactory.java:117)
	at retrofit2.OkHttpCall.createRawCall(OkHttpCall.java:192)
	at retrofit2.OkHttpCall.execute(OkHttpCall.java:175)
	at retrofit2.adapter.rxjava.CallExecuteOnSubscribe.call(CallExecuteOnSubscribe.java:40)
	at retrofit2.adapter.rxjava.CallExecuteOnSubscribe.call(CallExecuteOnSubscribe.java:24)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:48)
	at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.Observable.subscribe(Observable.java:10423)
	at rx.Observable.subscribe(Observable.java:10390)
	at rx.observables.BlockingObservable.forEach(BlockingObservable.java:111)

The parameter #10 is parameters which represent request body

The error is:
```
java.lang.IllegalArgumentException: Body parameter value must not be null. (parameter Azure#10)
    for method PipelinesService.createRun
	at retrofit2.Utils.methodError(Utils.java:52)
	at retrofit2.Utils.methodError(Utils.java:42)
	at retrofit2.Utils.parameterError(Utils.java:61)
	at retrofit2.ParameterHandler$Body.apply(ParameterHandler.java:408)
	at retrofit2.RequestFactory.create(RequestFactory.java:117)
	at retrofit2.OkHttpCall.createRawCall(OkHttpCall.java:192)
	at retrofit2.OkHttpCall.execute(OkHttpCall.java:175)
	at retrofit2.adapter.rxjava.CallExecuteOnSubscribe.call(CallExecuteOnSubscribe.java:40)
	at retrofit2.adapter.rxjava.CallExecuteOnSubscribe.call(CallExecuteOnSubscribe.java:24)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:48)
	at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.Observable.subscribe(Observable.java:10423)
	at rx.Observable.subscribe(Observable.java:10390)
	at rx.observables.BlockingObservable.forEach(BlockingObservable.java:111)
```

The parameter Azure#10 is `parameters` which represent request body
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 13, 2021
@ghost
Copy link

ghost commented Mar 13, 2021

Thank you for your contribution valfirst! We will review the pull request and get back to you soon.

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Mar 15, 2021

This is likely swagger bug.

Customer would better use the full overloaded method.

public Observable<ServiceResponse<CreateRunResponseInner>> createRunWithServiceResponseAsync(String resourceGroupName, String factoryName, String pipelineName, String referencePipelineRunId, Boolean isRecovery, String startActivityName, Boolean startFromFailure, Map<String, Object> parameters)

@weidongxu-microsoft weidongxu-microsoft merged commit b29a93a into Azure:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants