Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spring reference yaml #19874

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

yiliuTo
Copy link
Member

@yiliuTo yiliuTo commented Mar 16, 2021

This pr adjusts structure and keys of spring-reference.yaml:

  • Remove root key of spring.
  • Remove starter key and use type: spring | client | mgmt instead.
  • Add feature.msdocs property of each features except Azure Spring Boot Bom for it doesn't have doc.
  • Add springProperties key to mark all spring specific properties copied from https://github.com/spring-io/start.spring.io/blob/master/start-site/src/main/resources/application.yml.
  • Remove unused spring specific keys of scopes, facet and alias. We could add them back in case of future usage.
  • Add version key for mappings.compatibilityRange.
  • Modify links from list to map and update link key ghdocs to javadoc.
  • Add link key of github for github repo url.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 16, 2021
@yiliuTo
Copy link
Member Author

yiliuTo commented Mar 16, 2021

Hi @stliu and @wangmingliang-ms , please help to review the updates, thanks~

sdk/spring/spring-reference.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@backwind1233 backwind1233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiliuTo yiliuTo merged commit cce1ec3 into Azure:master Mar 17, 2021
@yiliuTo yiliuTo deleted the upadte-spring-reference-yaml branch March 22, 2021 08:29
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 18, 2022
Review request for Microsoft.ContainerService to add version 2022-07-02-preview (Azure#20062)

* Adds base for updating Microsoft.ContainerService from version preview/2022-06-02-preview to version 2022-07-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#19872)

* Add example of Azure KeyVault Secrets Provider Addon for 2022-07-02-preview (Azure#19874)

* add example of kv secret provider addon

* fix

* fix lint

* move ADH GA type to preview (Azure#19904)

* move ADH GA type to preview

* fix prettier check issue

* add overlay vpa swagger (Azure#19936)

* add overlay vpa objects

* fix typo

* address comments

Co-authored-by: zhifanhui <zhifanhui@microsoft.com>

* Swagger API for Operation Abort (Azure#19971)

* Swagger API for Operation Abort

* Swagger changes updates for Abort operation based on validations

* Haitao/secured by perimeter0702 (Azure#19873)

* add SecuredByPerimeter in publicNetworkAccess

* update enum value descriptions

* Add support for ImageCleaner on AKS (Azure#19916)

* Add support for ImageCleaner on AKS

* add more context in ImageCleaner description

* add default for availableAgentPoolVersions (Azure#19902)

* Add Azure Monitor Metrics (Prometheus) Profile (Azure#19965)

* Add Azure Monitor Metrics (Prometheus) Profile

* spelling error

* restructure to names from rp

* commit to rerun build

* ksm metrics

Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
Co-authored-by: huizhifan <60024380+huizhifan@users.noreply.github.com>
Co-authored-by: zhifanhui <zhifanhui@microsoft.com>
Co-authored-by: InduSridhar <InduSridhar@users.noreply.github.com>
Co-authored-by: Haitao Chen <haitch@users.noreply.github.com>
Co-authored-by: jiashun0011 <573255300@qq.com>
Co-authored-by: bragi92 <kadubey@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants