[Storage] Stress tests in pipeline? #21030

kasobol-msft · 2021-04-28T22:34:58Z

This PR adds basic coverage for APIs that are potentially memory-greedy, so they don't become greedier while code evolves.

Things to follow up separately observed during this experiment:

java 11 requires much more memory for some reason (e.g. upload sync works with 500mb on java8 but needs 700mb on java11). Opened [BUG] Buffered upload seem to require more memory than necessary. #21631
async scenarios run with insufficient heap just hang. See https://dev.azure.com/azure-sdk/internal/_build/results?buildId=899330&view=results . Created [BUG] Perf framework hangs while executing async scenario with insufficient heap. #21629
while experimenting with listing scenarios (not included here) I observed connection reset errors possibly not being re-tried by pageable types. Reopened [BUG] Connection reset by peer is not handled well by retry policy #21091

…ned-test

kasobol-msft · 2021-04-28T22:35:29Z

/azp run java - storage - tests

azure-pipelines · 2021-04-28T22:35:40Z

Azure Pipelines successfully started running 1 pipeline(s).

kasobol-msft · 2021-04-29T00:30:26Z

/azp run java - storage - tests

azure-pipelines · 2021-04-29T00:30:39Z

Azure Pipelines successfully started running 1 pipeline(s).

alzimmermsft · 2021-04-29T18:34:15Z

sdk/storage/tests.yml

+          displayName: 'Run Stress Scenarios'
+          inputs:
+              mavenPomFile: sdk/storage/azure-storage-perf/pom.xml
+              options: -Dstorage-stress-scenarios


I'd either add $(DefaultOptions) or --no-transfer-progress to options to reduce the verbosity of this step.

alzimmermsft · 2021-04-29T18:35:03Z

sdk/storage/tests.yml

@@ -47,6 +50,19 @@ stages:
          Path: sdk/storage/platform-matrix.json
          Selection: sparse
          GenerateVMJobs: true
+      PostSteps:
+        - task: Maven@3


Do we want to run this task if the test run fails? Also, if this step fails do we want to fail the job?

I think we can live with this not running if tests fail. We want to have green build. I'll check the later (but yes, we want to fail a job)

kasobol-msft · 2021-04-29T18:50:41Z

/azp run java - storage - tests

azure-pipelines · 2021-04-29T18:50:52Z

Azure Pipelines successfully started running 1 pipeline(s).

kasobol-msft · 2021-04-29T18:52:03Z

/azp run java - storage - tests

azure-pipelines · 2021-04-29T18:52:15Z

Azure Pipelines successfully started running 1 pipeline(s).

mikeharder

If this works as a reliable test, it looks good to me.

kasobol-msft · 2021-04-29T21:28:47Z

/check-enforcer override (no this pr :( )

kasobol-msft · 2021-04-30T00:24:51Z

/azp run java - storage - tests

azure-pipelines · 2021-04-30T00:25:18Z

Azure Pipelines successfully started running 1 pipeline(s).

…ned-test

kasobol-msft · 2021-05-17T21:26:32Z

/azp run java - storage - tests

kasobol-msft · 2021-05-17T21:54:01Z

/azp run java - storage - tests

azure-pipelines · 2021-05-17T21:54:29Z

Azure Pipelines successfully started running 1 pipeline(s).

kasobol-msft · 2021-05-17T22:18:37Z

/azp run java - storage - tests

azure-pipelines · 2021-05-17T22:18:48Z

Azure Pipelines successfully started running 1 pipeline(s).

kasobol-msft · 2021-05-17T22:36:04Z

/azp run java - storage - tests

kasobol-msft · 2021-05-18T04:25:00Z

/azp run java - storage - tests

azure-pipelines · 2021-05-18T04:25:12Z

Azure Pipelines successfully started running 1 pipeline(s).

kasobol-msft · 2021-05-18T04:36:20Z

/azp run java - storage - tests

azure-pipelines · 2021-05-18T04:36:30Z

Azure Pipelines successfully started running 1 pipeline(s).

kasobol-msft · 2021-05-18T21:09:17Z

/azp run java - storage - tests

azure-pipelines · 2021-05-18T21:09:29Z

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit ebd3e2c

kasobol-msft · 2021-05-18T21:12:01Z

/azp run java - storage - tests

azure-pipelines · 2021-05-18T21:12:16Z

Azure Pipelines successfully started running 1 pipeline(s).

…ompleted".

kasobol-msft · 2021-05-18T21:41:03Z

/azp run java - storage - tests

azure-pipelines · 2021-05-18T21:41:18Z

Azure Pipelines successfully started running 1 pipeline(s).

kasobol-msft · 2021-05-18T21:41:42Z

/azp run java - storage - tests

azure-pipelines · 2021-05-18T21:41:55Z

Azure Pipelines successfully started running 1 pipeline(s).

kasobol-msft added 3 commits April 28, 2021 15:17

draft.

e4a73b7

Merge remote-tracking branch 'upstream/master' into resource-constrai…

d7eb205

…ned-test

does this work ?

5f9a986

ghost added the Storage Storage Service (Queues, Blobs, Files) label Apr 28, 2021

try this.

40c3bd4

alzimmermsft reviewed Apr 29, 2021

View reviewed changes

well, here is verbosity...

be5a803

mikeharder approved these changes Apr 29, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into resource-constrai…

fbb7011

…ned-test

Azure deleted a comment from check-enforcer bot May 17, 2021

kasobol-msft added 2 commits May 17, 2021 15:10

disable tests temporarily

326ad61

try this.

a2d29c8

ugh..

478309b

this normally completes faster now.

15b0db1

kasobol-msft marked this pull request as ready for review May 18, 2021 05:17

kasobol-msft requested review from amishra-dev, benbp, gapra-msft, jaschrep-msft and rickle-msft as code owners May 18, 2021 05:17

kasobol-msft mentioned this pull request May 18, 2021

[BUG] Buffered upload seem to require more memory than necessary. #21631

Closed

gapra-msft approved these changes May 18, 2021

View reviewed changes

this isn't necessary.

ebd3e2c

kasobol-msft added 2 commits May 18, 2021 14:10

Revert "this isn't necessary."

b5afc84

This reverts commit ebd3e2c

this isn't necessary

ac33658

add assertion to make sure we don't regress "at least one operation c…

1964409

…ompleted".

mikeharder mentioned this pull request May 18, 2021

[Perf] Perf framework should allow last in-flight operation to complete #21635

Closed

mikeharder approved these changes May 18, 2021

View reviewed changes

kasobol-msft merged commit 32d85fb into Azure:master May 18, 2021

kasobol-msft deleted the resource-constrained-test branch May 18, 2021 22:14

g2vinay mentioned this pull request May 19, 2021

fix checkstyle issue #21656

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] Stress tests in pipeline? #21030

[Storage] Stress tests in pipeline? #21030

kasobol-msft commented Apr 28, 2021 •

edited

Loading

kasobol-msft commented Apr 28, 2021

azure-pipelines bot commented Apr 28, 2021

kasobol-msft commented Apr 29, 2021

azure-pipelines bot commented Apr 29, 2021

alzimmermsft Apr 29, 2021

alzimmermsft Apr 29, 2021

kasobol-msft Apr 29, 2021 •

edited

Loading

kasobol-msft Apr 30, 2021

kasobol-msft commented Apr 29, 2021

azure-pipelines bot commented Apr 29, 2021

kasobol-msft commented Apr 29, 2021

azure-pipelines bot commented Apr 29, 2021

mikeharder left a comment

kasobol-msft commented Apr 29, 2021 •

edited

Loading

kasobol-msft commented Apr 30, 2021

azure-pipelines bot commented Apr 30, 2021

kasobol-msft commented May 17, 2021

kasobol-msft commented May 17, 2021

azure-pipelines bot commented May 17, 2021

kasobol-msft commented May 17, 2021

azure-pipelines bot commented May 17, 2021

kasobol-msft commented May 17, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

[Storage] Stress tests in pipeline? #21030

[Storage] Stress tests in pipeline? #21030

Conversation

kasobol-msft commented Apr 28, 2021 • edited Loading

kasobol-msft commented Apr 28, 2021

azure-pipelines bot commented Apr 28, 2021

kasobol-msft commented Apr 29, 2021

azure-pipelines bot commented Apr 29, 2021

alzimmermsft Apr 29, 2021

Choose a reason for hiding this comment

alzimmermsft Apr 29, 2021

Choose a reason for hiding this comment

kasobol-msft Apr 29, 2021 • edited Loading

Choose a reason for hiding this comment

kasobol-msft Apr 30, 2021

Choose a reason for hiding this comment

kasobol-msft commented Apr 29, 2021

azure-pipelines bot commented Apr 29, 2021

kasobol-msft commented Apr 29, 2021

azure-pipelines bot commented Apr 29, 2021

mikeharder left a comment

Choose a reason for hiding this comment

kasobol-msft commented Apr 29, 2021 • edited Loading

kasobol-msft commented Apr 30, 2021

azure-pipelines bot commented Apr 30, 2021

kasobol-msft commented May 17, 2021

kasobol-msft commented May 17, 2021

azure-pipelines bot commented May 17, 2021

kasobol-msft commented May 17, 2021

azure-pipelines bot commented May 17, 2021

kasobol-msft commented May 17, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented May 18, 2021

azure-pipelines bot commented May 18, 2021

kasobol-msft commented Apr 28, 2021 •

edited

Loading

kasobol-msft Apr 29, 2021 •

edited

Loading

kasobol-msft commented Apr 29, 2021 •

edited

Loading