Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing reactor executor when IO pipe is closed. #22192

Merged
merged 7 commits into from
Jun 10, 2021
Merged

Closing reactor executor when IO pipe is closed. #22192

merged 7 commits into from
Jun 10, 2021

Conversation

conniey
Copy link
Member

@conniey conniey commented Jun 10, 2021 •
edited
Loading

  • Disposes of reactor scheduler when "IO Sink was interrupted".
  • Update CHANGELOG entry.

@conniey conniey force-pushed the conniey/close-executor branch from c498aa1 to c117dca Compare June 10, 2021 04:14
YijunXieMS
YijunXieMS approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@YijunXieMS YijunXieMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with long running test. "reactor-executor" threads were cleaned when "IO Sink was interrupted".

@conniey conniey enabled auto-merge (squash) June 10, 2021 16:50
@conniey conniey disabled auto-merge June 10, 2021 17:02
@conniey conniey enabled auto-merge (squash) June 10, 2021 17:17
@conniey conniey merged commit cfc40f8 into master Jun 10, 2021
@conniey conniey deleted the conniey/close-executor branch June 10, 2021 17:46
conniey added a commit to conniey/azure-sdk-for-java that referenced this pull request Jun 10, 2021
@conniey
Closing reactor executor when IO pipe is closed. (Azure#22192)
d33d106 
* When IO sink is disposed of, close the corresponding executor.

* Update ReactorExecutor to use AsyncCloseable.

* Removing unused method.

* Add changelog entry.
conniey added a commit that referenced this pull request Jun 10, 2021
@conniey @v-hongli1
Preparing for azure-core-amqp 2.2.0 release. (#22211)
71e46f1 
* Fix Management Bug (#22122)

* Adding missing return statement.

* Using common logic for status codes.

* Adding isSuccessful.

* Closing reactor executor when IO pipe is closed. (#22192)

* When IO sink is disposed of, close the corresponding executor.

* Update ReactorExecutor to use AsyncCloseable.

* Removing unused method.

* Add changelog entry.

* Fix Azure Core Amqp Sample issue #18806 by lihong 202105271344 (#21885)

* Running prepare-release script.

Co-authored-by: Hong Li(MSFT) <74638143+hongli750210@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzimmermsft alzimmermsft alzimmermsft left review comments

@YijunXieMS YijunXieMS YijunXieMS approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy

@danieljurek danieljurek Awaiting requested review from danieljurek

@g2vinay g2vinay Awaiting requested review from g2vinay

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@lmolkova lmolkova Awaiting requested review from lmolkova

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@mssfang mssfang Awaiting requested review from mssfang

@samvaity samvaity Awaiting requested review from samvaity

@schaabs schaabs Awaiting requested review from schaabs

@srnagar srnagar Awaiting requested review from srnagar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conniey @YijunXieMS @alzimmermsft