Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Make it easier to debug aad-starter #22289

Merged
merged 16 commits into from
Jun 30, 2021
Merged

[FEATURE REQ] Make it easier to debug aad-starter #22289

merged 16 commits into from
Jun 30, 2021

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Jun 15, 2021 •
edited
Loading

Fixes #21033

Changelog:

  • Add debugging log for user's authorities processing.
  • Add the readme section for user's authorities log usage.
  • Optimized the aad converter.

@ghost ghost added the azure-spring All azure-spring related issues label Jun 15, 2021
@chenrujun chenrujun self-assigned this Jun 16, 2021
@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

chenrujun
chenrujun suggested changes Jun 18, 2021
View reviewed changes
sdk/spring/azure-spring-boot-starter-active-directory-b2c/README.md Outdated Show resolved Hide resolved
...boot/src/main/java/com/azure/spring/aad/webapi/AADJwtBearerTokenAuthenticationConverter.java Outdated Show resolved Hide resolved
...boot/src/main/java/com/azure/spring/aad/webapi/AADJwtBearerTokenAuthenticationConverter.java Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory-b2c/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory-b2c/README.md Outdated Show resolved Hide resolved
...re-spring-boot/src/test/java/com/azure/spring/autoconfigure/b2c/AADB2CUserPrincipalTest.java Show resolved Hide resolved
...re-spring-boot/src/test/java/com/azure/spring/autoconfigure/b2c/AADB2CUserPrincipalTest.java Show resolved Hide resolved
...re-spring-boot/src/test/java/com/azure/spring/autoconfigure/b2c/AADB2CUserPrincipalTest.java Show resolved Hide resolved
...re-spring-boot/src/test/java/com/azure/spring/autoconfigure/b2c/AADB2CUserPrincipalTest.java Show resolved Hide resolved
...re-spring-boot/src/test/java/com/azure/spring/autoconfigure/b2c/AADB2CUserPrincipalTest.java Show resolved Hide resolved
@chenrujun chenrujun added this to the [2021] July milestone Jun 18, 2021
@chenrujun chenrujun added azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. labels Jun 18, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

chenrujun
chenrujun suggested changes Jun 22, 2021
View reviewed changes
sdk/spring/azure-spring-boot-starter-active-directory-b2c/CHANGELOG.md Show resolved Hide resolved
...boot/src/main/java/com/azure/spring/aad/webapi/AADJwtBearerTokenAuthenticationConverter.java Outdated Show resolved Hide resolved
...ain/java/com/azure/spring/autoconfigure/b2c/AADB2CJwtBearerTokenAuthenticationConverter.java Outdated Show resolved Hide resolved
...ain/java/com/azure/spring/autoconfigure/b2c/AADB2CJwtBearerTokenAuthenticationConverter.java Outdated Show resolved Hide resolved
...ain/java/com/azure/spring/autoconfigure/b2c/AADB2CJwtBearerTokenAuthenticationConverter.java Outdated Show resolved Hide resolved
.../src/test/java/com/azure/spring/aad/webapi/AADJwtBearerTokenAuthenticationConverterTest.java Outdated Show resolved Hide resolved
.../src/test/java/com/azure/spring/aad/webapi/AADJwtBearerTokenAuthenticationConverterTest.java Outdated Show resolved Hide resolved
@chenrujun chenrujun changed the title Add debug log and the authority log usage [FEATURE REQ] Make it easier to debug aad-starter Jun 25, 2021
@chenrujun
Copy link

Hi, @moarychan , please:

  1. Fix the pipeline failure: https://dev.azure.com/azure-sdk/public/_build/results?buildId=973474&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=ba3cf43a-b2bf-50f9-f95f-93049ca44ad1&l=283
  2. Resolve all the conversations.

chenrujun
chenrujun approved these changes Jun 30, 2021
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun merged commit c848f61 into Azure:main Jun 30, 2021
@moarychan moarychan deleted the feature/make-aad-app-easier-to-debug branch June 30, 2021 09:07
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Jan 28, 2023
CodeGen from PR 22289 in Azure/azure-rest-api-specs
4ea87d0 
Update OperationStatusResult To Reflect RPaaS Implementation (Azure#22289)

* Remove format:arm-id from v4 since api validation service fails to load the spec, causing global outages for RPaaS RPs

* referencing new OperationStatusResult

* fix async operation error in examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stliu stliu stliu left review comments

@chenrujun chenrujun chenrujun approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] July
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Make it easier to debug aad-starter
4 participants
@moarychan @chenrujun @stliu @rujche