Add TypingNotification options for setting SenderDisplayName #22351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angiurgiu
requested review from
ankitarorabit,
JianpingChen,
minnieliu and
a team
as code owners
ghost
added
the
.../session-records/ChatAsyncClientTest.canCreateNewThreadWithoutSettingRepeatabilityID[1].json
Show resolved
Hide resolved
juancamilor
reviewed
Jun 18, 2021
...ure-communication-chat/src/main/java/com/azure/communication/chat/ChatThreadAsyncClient.java
Show resolved
Hide resolved
...ure-communication-chat/src/main/java/com/azure/communication/chat/ChatThreadAsyncClient.java
Show resolved
Hide resolved
...nication-chat/src/main/java/com/azure/communication/chat/implementation/ChatThreadsImpl.java
Show resolved
Hide resolved
...nication-chat/src/main/java/com/azure/communication/chat/implementation/ChatThreadsImpl.java
Show resolved
Hide resolved
...nication-chat/src/main/java/com/azure/communication/chat/implementation/ChatThreadsImpl.java
Show resolved
Hide resolved
...nication-chat/src/main/java/com/azure/communication/chat/implementation/ChatThreadsImpl.java
Show resolved
Hide resolved
ChatThreadsImpl is the autogenerated class that our customers don't use, our own implementation with the consistent naming is built on top of it |
JianpingChen
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TypingNotification options for setting SenderDisplayName
Update Tests, Session Records
Update Readme, Changelog