More tests to improve coverage and fix LiveTests #22435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arifsaikat-microsoft
requested review from
ankitarorabit,
JianpingChen,
minnieliu and
a team
as code owners
ghost
added
the
…ttps://github.com/Azure/azure-sdk-for-java into arifsaikat/feature-communication-calling-livetest
…ttps://github.com/Azure/azure-sdk-for-java into arifsaikat/feature-communication-calling-livetest
minnieliu
reviewed
Jun 22, 2021
...n-callingserver/src/main/java/com/azure/communication/callingserver/CallConnectionAsync.java
Show resolved
Hide resolved
minnieliu
reviewed
Jun 22, 2021
...callingserver/src/test/java/com/azure/communication/callingserver/CallingServerTestBase.java
Outdated
Show resolved
Hide resolved
benbp
reviewed
Jun 22, 2021
|
What is the test coverage on calling after the new tests have been added now? |
…ttps://github.com/Azure/azure-sdk-for-java into arifsaikat/feature-communication-calling-livetest
After new tests added, current line coverage is 82% and branch coverage is 84%. We already have set min code coverage to 70% |
This reverts commit 375df59.
JianpingChen
approved these changes
Jun 22, 2021
benbp
approved these changes
Jun 22, 2021
minnieliu
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.