Fix user agent string #22454
Fix user agent string #22454
Conversation
| @@ -22,6 +22,7 @@ required-fields-as-ctor-args: true | |||
| model-override-setter-from-superclass: true | |||
| credential-types: tokencredential | |||
| client-side-validations: true | |||
| artifact-id: azure-monitor-query | |||
There was a problem hiding this comment.
This looks like a new addition to the autorest. How were the version and SDK being loaded until this was done. I don't think I did anything special for ACR but I do have the usual builder plumbing for it.
There was a problem hiding this comment.
Looks like ACR is missing azure-containers-containerregistry.properties file. Adding the above to your autorest config should generate this file and also update the builder to read from this file. This was manually done in the past, but now we have support for this in autorest.
There was a problem hiding this comment.
Thanks. I will create a TODO for myself :)
Also, for the token credential it may be worth exposing this as an overridable method that adds policy - in autorest, So that the builders can be used to create the rest of the pipeline but still extend the auth policy. Refers to: sdk/monitor/azure-monitor-query/src/main/java/com/azure/monitor/query/metricsnamespaces/implementation/MetricsNamespacesClientImplBuilder.java:240 in 8685024. [](commit_id = 8685024, deletion_comment = False) |
This PR fixes the user agent string to include the name and version of the SDK used. The update here is to set the
artifact-idin autorest configuration that generates theazure-monitor-query.propertiesand update the builders to read the values from the properties file.