Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased default maxRetries for download to help Connection reset by peer issues #22457

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Increased default maxRetries for download to help Connection reset by peer issues #22457

merged 2 commits into from
Jun 23, 2021

Conversation

gapra-msft
Copy link
Member

Resolves #22422 and helps resolve #22268

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 22, 2021
kasobol-msft
kasobol-msft approved these changes Jun 22, 2021
View reviewed changes
...c/test-shared/java/com/azure/storage/common/test/shared/policy/MockDownloadHttpResponse.java
to play too nicely with mocked objects and the complex reflection stuff on both ends made it more difficult to work
with than was worth it. Because this type is just for BlobDownload, we don't need to accept a header type.
*/
public class MockDownloadHttpResponse extends HttpResponse {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some work to be done here but beyond scope of this PR #22458

@gapra-msft gapra-msft marked this pull request as ready for review June 22, 2021 23:07
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@gapra-msft gapra-msft merged commit 8f808b2 into Azure:main Jun 23, 2021
@gapra-msft gapra-msft deleted the storage/downloadRetryDefault branch June 23, 2021 00:17
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Feb 22, 2023
@MikhailTryakhov @krishmi
@krmishr-msft @Khushboo-Baheti @utbarn-ms @tejasshah7 @prateek2211
CodeGen from PR 22639 in Azure/azure-rest-api-specs
7072a15 
Networking 2022-09-01 release (Azure#22639)

* Adds base for updating Microsoft.Network from version stable/2022-07-01 to version 2022-09-01

* Updates readme

* Updates API version in new specs and examples

* Added flowlog property in virtual network (Azure#21790)

Co-authored-by: Krishna Mishra <krmishr@microsoft.com>

* commit1 (Azure#22111)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* adding auth status property to circuit (Azure#22024)

* Make auth status readonly (Azure#22365)

* make auth status read only

* fixing model validation

* prettier fix

* Add support for State flag in Custom Rule (Azure#22457)

* Fix LRO header model validation (Azure#22506)

* Add new status code for application gateway custom error page (Azure#22151)

* Add new status code for application gateway custom error page

* Fix prettier

* Adding words to Custom-Words list

* Fix missing resource id in application gateway list example (Azure#22509)

* Resolving merge conflicts with main branch

---------

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: KRISHNA MISHRA <krishmi139@gmail.com>
Co-authored-by: Krishna Mishra <krmishr@microsoft.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com>
Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
Co-authored-by: Prateek Sachan <42961174+prateek2211@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Feb 22, 2023
@MikhailTryakhov @krishmi
@krmishr-msft @Khushboo-Baheti @utbarn-ms @tejasshah7 @prateek2211
CodeGen from PR 22639 in Azure/azure-rest-api-specs
fc47d3f 
Networking 2022-09-01 release (Azure#22639)

* Adds base for updating Microsoft.Network from version stable/2022-07-01 to version 2022-09-01

* Updates readme

* Updates API version in new specs and examples

* Added flowlog property in virtual network (Azure#21790)

Co-authored-by: Krishna Mishra <krmishr@microsoft.com>

* commit1 (Azure#22111)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* adding auth status property to circuit (Azure#22024)

* Make auth status readonly (Azure#22365)

* make auth status read only

* fixing model validation

* prettier fix

* Add support for State flag in Custom Rule (Azure#22457)

* Fix LRO header model validation (Azure#22506)

* Add new status code for application gateway custom error page (Azure#22151)

* Add new status code for application gateway custom error page

* Fix prettier

* Adding words to Custom-Words list

* Fix missing resource id in application gateway list example (Azure#22509)

* Resolving merge conflicts with main branch

---------

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: KRISHNA MISHRA <krishmi139@gmail.com>
Co-authored-by: Krishna Mishra <krmishr@microsoft.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com>
Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
Co-authored-by: Prateek Sachan <42961174+prateek2211@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasobol-msft kasobol-msft kasobol-msft approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
3 participants
@gapra-msft @alzimmermsft @kasobol-msft