Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue that prevented creating while providing an AzureNamedKeyCredential as the sole form of authentication. #22492

Merged
merged 5 commits into from
Jun 24, 2021

Conversation

vcolin7
Copy link
Member

@vcolin7 vcolin7 commented Jun 24, 2021

Fixes #22384.

Created this PR in place of #22438 as I had to delete the fork it came from to clean some stuff up.

@vcolin7
Copy link
Member Author

vcolin7 commented Jun 24, 2021

About your comment @alzimmermsft, we use the method you mention on the builder before calling buildPipeline(). I tried having all that happen in BuilderHelper but it was getting a bit complicated and I had limited time. I can explore that option again if you think we should do it before we merge this PR.

@vcolin7 vcolin7 requested review from samvaity, g2vinay and srnagar June 24, 2021 05:45
@vcolin7 vcolin7 added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jun 24, 2021
@vcolin7 vcolin7 self-assigned this Jun 24, 2021
@vcolin7 vcolin7 merged commit a41d8d4 into Azure:main Jun 24, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Mar 14, 2023
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-02-01 (Azure#22492)

* Adds base for updating Microsoft.RecoveryServices from version stable/2023-01-01 to version 2023-02-01

* Updates readme

* Updates API version in new specs and examples

* Adding Restore Settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TableServiceClientBuilder.buildAsyncClient() disobeyes azureNamedKeyCredential
2 participants