Added support for file share reliable download #22504
Conversation
ghost
added
the
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
| if ((eTag == null && receivedETag == null) | ||
| || (eTag != null && eTag.equals(receivedETag))) { |
There was a problem hiding this comment.
should we assume etag isn't null? What would be scenario it is null ?
| if (headers == null) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
should we assume headers aren't null ?
There was a problem hiding this comment.
that seems like a fair assumption. Will remove.
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…re-sdk-for-java into storage/fileShareReliable
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
No description provided.