Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent problem in key vault certificates #22535

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix concurrent problem in key vault certificates #22535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60875a4
Fix concurrent problem in KeyVaultCertificates.
rujche Jun 24, 2021
5b59085
Fix concurrent problem in KeyVaultCertificates.
rujche Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...rity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultCertificates.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,16 @@ public Map<String, Key> getCertificateKeys() {
}

private void refreshCertificatesIfNeeded() {
if (certificatesNeedRefresh()) {
if (certificatesNeedRefresh()) { // Avoid acquiring the lock as much as possible.
refreshCertificates();
}
}

private void refreshCertificates() {
private synchronized void refreshCertificates() {
if (!certificatesNeedRefresh()) {
return; // After obtaining the lock, avoid doing too many operations.
}
// When refreshing certificates, the update of the 3 variables should be an atomic operation.
aliases = keyVaultClient.getAliases();
certificateKeys.clear();
certificates.clear();
Expand Down