Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating code owners +ki1729 -hemanttanwar #22617

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

ki1729
Copy link
Contributor

@ki1729 ki1729 commented Jun 28, 2021

No description provided.

@ki1729 ki1729 requested a review from YijunXieMS June 28, 2021 17:27
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@ki1729
Copy link
Contributor Author

ki1729 commented Jun 29, 2021

/check-enforcer override

@ki1729 ki1729 merged commit 33c0e69 into Azure:main Jun 29, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Mar 9, 2023
[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2023-02-01-preview (Azure#22436)

* Adds base for updating Microsoft.MachineLearningServices from version preview/2022-12-01-preview to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add managedResourceGroupTags to registries Feb 2023 Preview swagger (Azure#22617)

* removed feb2023 registries.json

* Revert "removed feb2023 registries.json"

This reverts commit d2d1f7055e00284ba040cf0b792404956fb89c24.

* add managedResourceGroupTags property

---------

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* updating to feb 2023 preview (Azure#22456)

* updating to feb 2023 preview

* adding example files

* add to custom words, remove spelling errors

* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>

* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>

* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>

* resolving model validation errors

* try resolving operation async response validation errors

* merge data container/ver, queue settings

* add datacontainer and version example files, add LRO uri

* update example jobs files, update LRO and registry name pattern

* last LRO fixes

* test that batchdeploymentproperties is resolved

* adding maulik's swagger generation PR changes

* update swagger with new deduped batch names

* adding updated computeresource name

* add boolean featuredatatype

---------

Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>

* ManagedNetwork Support and paramter parttern update for WorkspaceRP (Azure#22588)

* add swagger support for managed network

* update parameter pattern

* Add rules

* remove unused file

* fix

* fix format and add pattern

* update format and example

* revert manage network changes

* small change

* revert

* Staging Branch Gate Fixes and Schema Bug Fix for ModelPackage (Azure#22784)

* updating to feb 2023 preview

* adding example files

* add to custom words, remove spelling errors

* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>

* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>

* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json

Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>

* resolving model validation errors

* try resolving operation async response validation errors

* merge data container/ver, queue settings

* add datacontainer and version example files, add LRO uri

* update example jobs files, update LRO and registry name pattern

* last LRO fixes

* test that batchdeploymentproperties is resolved

* adding maulik's swagger generation PR changes

* update swagger with new deduped batch names

* adding updated computeresource name

* add boolean featuredatatype

* fixing model validation pattern error

* fix LRO gate

* adding model package updates to swagger

* un requiring property

---------

Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>

---------

Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com>
Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants