Enable properties which supported in sdk #22676

zhichengliu12581 · 2021-06-30T09:28:20Z

enable properties which supported in sdk
related pr

check-enforcer · 2021-07-02T03:04:01Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

…to enable-properties-which-supported-in-sdk

...ring/azure-spring-cloud-test-servicebus-binder/src/test/resources/application-properties.yml

stliu · 2021-07-14T08:05:49Z

docs?

zhichengliu12581 · 2021-07-14T08:11:43Z

@stliu I'm waiting for the review for this pr, which have conflict with this pr. I plan to modify the document and changelog after that pr merge. Or I can add it temporarily, and then modify it again after that pr merge?

…to enable-properties-which-supported-in-sdk

yiliuTo · 2021-07-24T14:04:56Z

...src/main/java/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusProperties.java

@@ -16,6 +18,8 @@

    private String connectionString;

+    private AmqpRetryOptions retryOptions = new AmqpRetryOptions().setTryTimeout(ServiceBusConstants.OPERATION_TIMEOUT);


Is this default value for servicebus sdk client? If so, seems we don't set it here

backwind1233 · 2021-07-29T22:29:58Z

sdk/spring/azure-spring-cloud-autoconfigure/CHANGELOG.md

+- Support configuration of `serviceBusReceiveMode` for ServiceBusClientConfig with property of `spring.cloud.stream.servicebus.<queue or topic>.bindings.<channelName>.consumer.serviceBusReceiveMode`, supported values are `PEEK_LOCK` and `RECEIVE_AND_DELETE`.
+- Support configuration of `enableAutoComplete` for ServiceBusClientConfig with property of `spring.cloud.stream.servicebus.queue.bindings.<channelName>.consumer.enableAutoComplete`.
+### Breaking Changes
+- Deprecated the `spring.cloud.stream.servicebus.queue.bindings.<channelName>.consumer.concurrency` property,


Deprecated --> Deprecate

backwind1233 · 2021-07-29T22:38:17Z

...a/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusQueueAutoConfiguration.java

@@ -63,6 +63,8 @@ public ServiceBusQueueClientFactory queueClientFactory(
        Assert.notNull(connectionString, "Service Bus connection string must not be null");

        DefaultServiceBusQueueClientFactory clientFactory = new DefaultServiceBusQueueClientFactory(connectionString, properties.getTransportType());
+        clientFactory.retryOptions(properties.getRetryOptions());
+


can we delete the empty line here?

backwind1233 · 2021-07-29T22:38:23Z

...a/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusTopicAutoConfiguration.java

@@ -72,6 +72,8 @@ public ServiceBusTopicClientFactory topicClientFactory(
        Assert.notNull(connectionString, "Service Bus connection string must not be null");

        DefaultServiceBusTopicClientFactory clientFactory = new DefaultServiceBusTopicClientFactory(connectionString, properties.getTransportType());
+        clientFactory.retryOptions(properties.getRetryOptions());
+


can we delete the empty line here?

yiliuTo · 2021-07-30T02:55:36Z

/azp run java - spring - tests

azure-pipelines · 2021-07-30T02:55:50Z

Azure Pipelines successfully started running 1 pipeline(s).

yiliuTo · 2021-07-30T05:44:03Z

/azp run java - spring - tests

azure-pipelines · 2021-07-30T05:44:16Z

Azure Pipelines successfully started running 1 pipeline(s).

…ith concurrency

yiliuTo · 2021-08-02T02:22:19Z

/azp run java - spring - tests

azure-pipelines · 2021-08-02T02:22:31Z

Azure Pipelines successfully started running 1 pipeline(s).

yiliuTo · 2021-08-03T03:26:03Z

/azp run java - spring - tests

azure-pipelines · 2021-08-03T03:26:21Z

Azure Pipelines successfully started running 1 pipeline(s).

yiliuTo

lgtm

zhichengliu12581 added 3 commits June 30, 2021 17:19

Support the parameters that are allowed to be configured in the SDK

ffb59f4

nothing changed, just remove unused import

00356c6

support configuration in topic

f3071b1

ghost added the azure-spring All azure-spring related issues label Jun 30, 2021

zhichengliu12581 added 4 commits June 30, 2021 18:24

try to fix pipeline error

7f982bc

merge master

ca7d039

remove useless bean

f876d85

add properties in consumer Properties

48c8ccc

zhichengliu12581 added 9 commits July 5, 2021 11:06

remove unused import

922759a

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

c0f6557

…to enable-properties-which-supported-in-sdk

add default client options

5939585

revert useless bean as discussed

2380f9f

add test for retry-options properties

65d8abf

add test for serviceBusReceiveMode properties

c276787

nothing changed, just remove Todo

4245f00

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

4ca6492

…to enable-properties-which-supported-in-sdk

nothing changed just remove unused import and format code

ec9736b

stliu reviewed Jul 14, 2021

View reviewed changes

...ring/azure-spring-cloud-test-servicebus-binder/src/test/resources/application-properties.yml Outdated Show resolved Hide resolved

zhichengliu12581 added 2 commits July 23, 2021 09:36

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

54e8474

…to enable-properties-which-supported-in-sdk

update CHANGELOG.md and README.md

379c430

zhichengliu12581 marked this pull request as ready for review July 23, 2021 02:35

zhichengliu12581 requested review from backwind1233, chenrujun, saragluna and yiliuTo as code owners July 23, 2021 02:35

remove unused import

dc87561

yiliuTo reviewed Jul 24, 2021

View reviewed changes

try to fix pipeline error

de0880e

backwind1233 reviewed Jul 29, 2021

View reviewed changes

update by comments

cbec683

zhichengliu12581 added 2 commits July 30, 2021 11:57

merge main

4c8688d

merge main

d32503d

zhichengliu12581 added 6 commits July 30, 2021 14:26

rename functions

916160a

make maxConcurrentCalls and maxConcurrentSessions can work normally w…

58245ed

…ith concurrency

remove useless it

fd05168

make properties as pojo

9bc8c6d

merge main

9b223dc

fix README.md error

c134b56

yiliuTo self-assigned this Aug 2, 2021

zhichengliu12581 and others added 4 commits August 2, 2021 10:56

fix pipeline error

c8ccb03

add test for properties

6c86b9a

Update ServiceBusQueueSessionBinderConfigTest.java

e91660b

fix pipeline error

efdc850

yiliuTo approved these changes Aug 4, 2021

View reviewed changes

yiliuTo merged commit 26879b6 into Azure:main Aug 4, 2021

yiliuTo mentioned this pull request Aug 5, 2021

Additional consumer and producer properties for Service Bus #21542

Closed

zhichengliu12581 deleted the enable-properties-which-supported-in-sdk branch August 24, 2021 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable properties which supported in sdk #22676

Enable properties which supported in sdk #22676

zhichengliu12581 commented Jun 30, 2021 •

edited

Loading

check-enforcer bot commented Jul 2, 2021

stliu commented Jul 14, 2021

zhichengliu12581 commented Jul 14, 2021 •

edited

Loading

yiliuTo Jul 24, 2021

backwind1233 Jul 29, 2021

backwind1233 Jul 29, 2021

backwind1233 Jul 29, 2021

yiliuTo commented Jul 30, 2021

azure-pipelines bot commented Jul 30, 2021

yiliuTo commented Jul 30, 2021

azure-pipelines bot commented Jul 30, 2021

yiliuTo commented Aug 2, 2021

azure-pipelines bot commented Aug 2, 2021

yiliuTo commented Aug 3, 2021

azure-pipelines bot commented Aug 3, 2021

yiliuTo left a comment

		@@ -16,6 +18,8 @@

		private String connectionString;

		private AmqpRetryOptions retryOptions = new AmqpRetryOptions().setTryTimeout(ServiceBusConstants.OPERATION_TIMEOUT);

Enable properties which supported in sdk #22676

Enable properties which supported in sdk #22676

Conversation

zhichengliu12581 commented Jun 30, 2021 • edited Loading

check-enforcer bot commented Jul 2, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

stliu commented Jul 14, 2021

zhichengliu12581 commented Jul 14, 2021 • edited Loading

yiliuTo Jul 24, 2021

Choose a reason for hiding this comment

backwind1233 Jul 29, 2021

Choose a reason for hiding this comment

backwind1233 Jul 29, 2021

Choose a reason for hiding this comment

backwind1233 Jul 29, 2021

Choose a reason for hiding this comment

yiliuTo commented Jul 30, 2021

azure-pipelines bot commented Jul 30, 2021

yiliuTo commented Jul 30, 2021

azure-pipelines bot commented Jul 30, 2021

yiliuTo commented Aug 2, 2021

azure-pipelines bot commented Aug 2, 2021

yiliuTo commented Aug 3, 2021

azure-pipelines bot commented Aug 3, 2021

yiliuTo left a comment

Choose a reason for hiding this comment

zhichengliu12581 commented Jun 30, 2021 •

edited

Loading

zhichengliu12581 commented Jul 14, 2021 •

edited

Loading