Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing loading correct class bug that Naveen found #22689

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

moderakh
Copy link
Contributor

fixing loading correct class bug that Naveen found

Copy link
Member

@simplynaveen20 simplynaveen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moderakh moderakh enabled auto-merge (squash) June 30, 2021 21:31
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@simplynaveen20 simplynaveen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also please change the exception message as well, we are using CosmosQueryRequestOptionsHelper in all these helper

@moderakh
Copy link
Contributor Author

moderakh commented Jul 1, 2021

Can we also please change the exception message as well, we are using CosmosQueryRequestOptionsHelper in all these helper

could you refer to the actual code, it is not clear to me what you are referring to and which scenario you are pointing at.

@moderakh
Copy link
Contributor Author

moderakh commented Jul 1, 2021

Can we also please change the exception message as well, we are using CosmosQueryRequestOptionsHelper in all these helper

discussed offline to understand the comment. Thanks for the comment. I addressed in the last commit.

@check-enforcer
Copy link

check-enforcer bot commented Jul 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@moderakh moderakh merged commit 071ca6a into Azure:main Jul 2, 2021
@moderakh moderakh deleted the users/moderakh/bugfix-class-loading branch July 2, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants