CosmosDB: fix a regression in ChangeFeedProcessor when handling split events #22718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom zero for the new partitions. This is a regression introduced in SDK version 4.12 as part of the change feed pull model related changes. The fix is to directly set the "parent" lease continuation token into the new leases that get created as result of a split.
milismsft
added
the
cosmos:v4-item
milismsft
requested review from
aayush3011,
FabianMeiswinkel,
kirankumarkolli,
kushagraThapar,
mbhaskar,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
j82w
previously requested changes
Jul 1, 2021
...ava/com/azure/cosmos/implementation/changefeed/implementation/PartitionSynchronizerImpl.java
Show resolved
Hide resolved
j82w
reviewed
Jul 1, 2021
j82w
dismissed
their stale review
Unblocking the PR, but still believe some test needs to be added to verify this scenario and prevent future regressions.
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…e NPE exceptions could be triggered.
j82w
approved these changes
Jul 4, 2021
|
/azp run java - cosmos - test |
|
No pipelines are associated with this pull request. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When partition splitting occurs, we wrongly resume the change feeds from zero for the new partitions.
This is a regression introduced in SDK version 4.12 as part of the change feed pull model related changes.
The fix is to directly set the "parent" lease continuation token into the new leases that get created as result of a split.