Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete un-supported AAD features. #23895

Merged
merged 5 commits into from
Sep 7, 2021
Merged

Delete un-supported AAD features. #23895

merged 5 commits into from
Sep 7, 2021

Conversation

chenrujun
Copy link

@chenrujun chenrujun commented Sep 3, 2021 •
edited
Loading

Resolve #23922

@rujche
Delete AADAuthenticationFilter and AADAppRoleStatelessAuthenticationF…
c0ec025 
…ilter, because they are deprecated and will not supported any more in version 4.0.
@chenrujun chenrujun self-assigned this Sep 3, 2021
@ghost ghost added the azure-spring All azure-spring related issues label Sep 3, 2021
@chenrujun chenrujun added azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Sep 3, 2021
@chenrujun chenrujun added this to the [2021] October milestone Sep 3, 2021
@chenrujun chenrujun linked an issue Sep 3, 2021 that may be closed by this pull request
Implement azure-spring-security 4.0 #23710
Closed
4 tasks
@stliu
Copy link
Member

stliu commented Sep 3, 2021

is this PR finished?
I can only see you deleted a bunch of staff

@chenrujun
Copy link
Author

is this PR finished?
I can only see you deleted a bunch of staff

@stliu ,
No, It's not finished.
But it's OK to review, If we review it after finished all parts, it will be difficult (too big) to review.
So I suggest to review commits.

If the reviewer think current commits is OK to merge, I'll merge it.

@stliu
Copy link
Member

stliu commented Sep 3, 2021

but how to say "OK" safely with incompletable information?

@chenrujun
Copy link
Author

chenrujun commented Sep 3, 2021 •
edited
Loading

but how to say "OK" safely with incompletable information?

One commit is a complete information, it's a stand alone task. （We can view a commit as a small PR.）
So I suggest reviewers review this PR by commits.

image

@stliu
Copy link
Member

stliu commented Sep 3, 2021

I can only see you deleted something in a commit, if that's the completed information, then of course I'd say no, why delete those files? don't we need them anymore?

@chenrujun
Copy link
Author

why delete those files? don't we need them anymore?

Yes, we don't need them any more.
These features are not suggested to use by Azure Active Directory team. (And it's not a standard usage.)
These features are already deprecated in version 3.x.x.
So I plan to delete them in version 4.0.0.

@rujche
Delete deprecated feature: authorize by group-name, group-id.
97fbf77 
This feature is deprecated in version 3.x.
We will not support these features in 4.0.0.

I found the first PR of this feature: microsoft/azure-spring-boot#97
It's on 2017-08-07.

At that time, there is no spring-security-oauth2-resource-server.
spring-security-oauth2-resource-server first released on 2018-09-21.

refs:

https://repo1.maven.org/maven2/org/springframework/security/spring-security-oauth2-resource-server/
@stliu
Copy link
Member

stliu commented Sep 3, 2021

if so, wouldn't it be more appreciated to have separated PR for each task instead of all grouped into this general "implement azure spring security 4.0"?

for example, this removes some feature, I think it deserves its own github issue with detailed info of :

  • why
  • how to migrate

@chenrujun
Copy link
Author

if so, wouldn't it be more appreciated to have separated PR for each task instead of all grouped into this general "implement azure spring security 4.0"?

If I do like that, then PR2 depends on PR1, and PR3 depends on PR 2, etc..
We can let PR2 have commits of PR1, and PR3 depends on PR2. Do like this will have a problem: If PR 1 have more commits, the both PR2 and PR3 need rebase.

So I prefer to use one PR.

how to migrate

My current plan is write doc after coding work finished.

@stliu
Copy link
Member

stliu commented Sep 3, 2021

NO, pull request is not working like what your describe.

One PR should do one specific change, having a corresponding issues link to it
in this case, I suggest you create a issue ( probably should be a sub-task of implementing azure spring security 4.0) to remove the code.
btw, this sub-task is what I asked "task list"

you can't use one PR to do all the works, that would make things untrackable.

@chenrujun chenrujun changed the title Implement Azure Spring Security 4.0 Delete un-supported AAD features. Sep 6, 2021
@chenrujun chenrujun linked an issue Sep 6, 2021 that may be closed by this pull request
Delete un-supported AAD features. #23922
Closed
@chenrujun chenrujun removed a link to an issue Sep 6, 2021
Implement azure-spring-security 4.0 #23710
Closed
4 tasks
@check-enforcer
Copy link

check-enforcer bot commented Sep 6, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@chenrujun
Copy link
Author

/azp run java - spring - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link
Author

Hi, @stliu .
I updated the PR's title, and created new issue to track this PR.

Hi, @saragluna , @zhichengliu12581 .
Could you please help to review this PR when you have time?

@chenrujun chenrujun merged commit d5ce19a into Azure:feature/azure-spring-cloud-4.0 Sep 7, 2021
@chenrujun chenrujun deleted the Implement_azure-spring-security_4.0 branch September 7, 2021 06:47
zhichengliu12581 added a commit to zhichengliu12581/azure-sdk-for-java that referenced this pull request Sep 13, 2021
@zhichengliu12581
Delete test because these features has already been deleted in Azure#…
5736bfb 
…23895
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request May 12, 2023
CodeGen from PR 23895 in Azure/azure-rest-api-specs
871b934 
Fixed double header issue (Azure#23895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stliu stliu stliu approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@michaelqi793 michaelqi793 Awaiting requested review from michaelqi793

@moarychan moarychan Awaiting requested review from moarychan

@saragluna saragluna Awaiting requested review from saragluna

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@zhichengliu12581 zhichengliu12581 Awaiting requested review from zhichengliu12581

@ZhuXiaoBing-cn ZhuXiaoBing-cn Awaiting requested review from ZhuXiaoBing-cn

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2021] October
Development

Successfully merging this pull request may close these issues.

Delete un-supported AAD features.
3 participants
@chenrujun @stliu @rujche