Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a NullPointerException in VirtualMachineImpl #24154

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fixed a NullPointerException in VirtualMachineImpl #24154

merged 1 commit into from
Sep 16, 2021

Conversation

Fabio1988
Copy link
Contributor

NPE occurs when requesting osUnmanagedDiskVhdUri() but no VHD is present in the VirtualMachine.
it's happening because of method chaining without NPE-check before.

NPE occurs when requesting osUnmanagedDiskVhdUri() but no VHD is present in the VirtualMachine.
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 15, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

Thank you for your contribution Fabio1988! We will review the pull request and get back to you soon.

@weidongxu-microsoft
Copy link
Member

@Fabio1988 Thanks for the fix!
2.8.0 is released a day before. So the change will be in 2.9.0 which is about a month later.

@weidongxu-microsoft weidongxu-microsoft merged commit 7587837 into Azure:main Sep 16, 2021
@Fabio1988
Copy link
Contributor Author

Fabio1988 commented Sep 16, 2021

Oh I was quite late, so I will wait for next release, thanks :)

Is there also an ETA when it will be released in following dependency https://mvnrepository.com/artifact/com.microsoft.azure/azure ? :)

@weidongxu-microsoft
Copy link
Member

@Fabio1988
com.microsoft.azure:azure (https://github.com/Azure/azure-libraries-for-java) is actually an older version of this SDK com.azure:azure-resourcemanager (https://aka.ms/azsdk/java/mgmt).

com.microsoft.azure:azure is in maintenance mode so the release will be sparse. I can sync your fix to it, but next release is not scheduled.

srnagar pushed a commit to srnagar/azure-sdk-for-java that referenced this pull request Sep 20, 2021
NPE occurs when requesting osUnmanagedDiskVhdUri() but no VHD is present in the VirtualMachine.
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Jun 13, 2023
Release network microsoft.network official 2023 02 01 (Azure#24277)

* Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01

* Updates readme

* Updates API version in new specs and examples

* Fixed double header issue (Azure#23896)

* Edited description for additional nics (Azure#24071)

* swagger 20230201 adding resource guid (Azure#24154)

* Appgw: Remove 499 status code from custom error page (Azure#24095)

* Add AdminState Property to Virtual Network Gateway Resource Properties (Azure#23978)

* add adminstate

* update description

* add headers to 202

* prettier fix

* AppGW: Add default predefined ssl policy field in resource (Azure#24094)

* Fix examples (Azure#24274)

---------

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com>
Co-authored-by: sssharma24 <107450300+sssharma24@users.noreply.github.com>
Co-authored-by: Prateek Sachan <42961174+prateek2211@users.noreply.github.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Sindhu Aluguvelli <sindhureddy216@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants