Remove validation dependency #25335

backwind1233 · 2021-11-11T07:56:40Z

This PR is mainly about

Remove the validation dependency spring-boot-starter-validation to simplify module dependency.
Add a new starter -- spring-cloud-azure-starter-data-cosmos

Spring artifact Id	Dependency
spring-cloud-azure-starter-cosmos	azure-cosmos
spring-cloud-azure-starter-data-cosmos	azure-spring-data-cosmos

backwind1233 · 2021-11-11T07:56:52Z

/azp run java - spring - tests

azure-pipelines · 2021-11-11T07:57:06Z

Azure Pipelines successfully started running 1 pipeline(s).

check-enforcer · 2021-11-11T08:07:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

backwind1233 · 2021-11-11T09:09:46Z

/azp run java - spring - ci

azure-pipelines · 2021-11-11T09:10:08Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna · 2021-11-11T15:43:52Z

/azp run java - spring - tests

azure-pipelines · 2021-11-11T15:44:05Z

Azure Pipelines successfully started running 1 pipeline(s).

backwind1233 · 2021-11-12T15:47:09Z

/azp run java - spring - ci

azure-pipelines · 2021-11-12T15:47:26Z

Azure Pipelines successfully started running 1 pipeline(s).

…dency_gzh # Conflicts: # sdk/spring/spring-cloud-azure-starter-cosmos/pom.xml

…dency_gzh

chenrujun · 2021-11-16T06:14:47Z

.../cloud/autoconfigure/active/directory/implementation/autoconfigure/b2c/AADB2CProperties.java

-                throw new AADB2CConfigurationException("Sign in user flow key '"
-                    + loginFlow + "' is not in 'user-flows' map.");
-            }
+        if (!isValidURL(logoutSuccessUrl)) {


This should move into validateURLProperties?

chenrujun · 2021-11-16T06:15:26Z

.../cloud/autoconfigure/active/directory/implementation/autoconfigure/b2c/AADB2CProperties.java

+        if (!isValidURL(logoutSuccessUrl)) {
+            throw new AADB2CConfigurationException("logout success should be valid URL.");
+        }
+        if (!isValidURL(baseUri)) {


In original logic, baseUri can be empty, but now it can't.

chenrujun · 2021-11-16T06:16:17Z

.../cloud/autoconfigure/active/directory/implementation/autoconfigure/b2c/AADB2CProperties.java

+     */
+    private void validateURLProperties() {
+        if (!CollectionUtils.isEmpty(userFlows)) {
+            if (!StringUtils.hasText(tenant) && !StringUtils.hasText(baseUri)) {


!StringUtils.hasText(tenant) is not belong to validateURLProperties. The method name will make the code confusing.

…dency_gzh

backwind1233 · 2021-11-16T07:30:37Z

/azp run java - spring - tests

azure-pipelines · 2021-11-16T07:30:50Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna · 2021-11-16T09:04:23Z

/azp run java - spring - tests

azure-pipelines · 2021-11-16T09:04:36Z

Azure Pipelines successfully started running 1 pipeline(s).

stliu · 2021-11-16T11:42:39Z

.../cloud/autoconfigure/active/directory/implementation/autoconfigure/b2c/AADB2CProperties.java

+     * @param uri
+     * @return whether is uri is valid or not.
+     */
+    private boolean isValidURL(String uri) {


this should be a more common util, thus should be located in a util class in core , this properties class is not the proper place

.../main/java/com/azure/spring/cloud/autoconfigure/cosmos/properties/AzureCosmosProperties.java

stliu · 2021-11-16T11:44:32Z

A PR should contains one thing, apperently this PR does alot more than what the title / description said

…dency_gzh

backwind1233 · 2021-11-17T02:16:24Z

/azp run java - spring - tests

azure-pipelines · 2021-11-17T02:16:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2021-11-17T05:25:39Z

API changes have been detected in com.azure:azure-core. You can review API changes here

API changes

+     public enum ErrorOptions {
+         THROW,
+         NO_THROW;
+     }
+         public RequestOptions setErrorOptions(EnumSet<ErrorOptions> errorOptions)

backwind1233 · 2021-11-17T06:03:05Z

/azp run java - spring - tests

backwind1233 · 2021-11-17T06:03:14Z

/azp run java - spring - ci

azure-pipelines · 2021-11-17T06:03:18Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2021-11-17T06:03:31Z

Azure Pipelines successfully started running 1 pipeline(s).

remove validation library

51e39d3

backwind1233 requested review from chenrujun, moarychan, saragluna, stliu, yiliuTo and zhichengliu12581 as code owners November 11, 2021 07:56

ghost added the azure-spring All azure-spring related issues label Nov 11, 2021

add spring-cloud-azure-starter-data-cosmos

a627507

backwind1233 requested review from alzimmermsft, anuchandy, conniey, g2vinay, hallipr, JonathanGiles, joshfree, lmolkova, pallavit, samvaity and srnagar as code owners November 11, 2021 08:43

Merge branch 'feature/azure-spring-cloud-4.0' into 211111_updatedepen…

0a5d938

…dency_gzh # Conflicts: # sdk/spring/spring-cloud-azure-starter-cosmos/pom.xml

backwind1233 added 4 commits November 16, 2021 10:34

Merge branch 'feature/azure-spring-cloud-4.0' into 211111_updatedepen…

53ce92c

…dency_gzh

test cosmos

b5e20eb

remove validation in cosmos

a97a228

remove @url annotation in AADB2CProperties

8a217fe

chenrujun reviewed Nov 16, 2021

View reviewed changes

backwind1233 added 2 commits November 16, 2021 15:19

Merge branch 'feature/azure-spring-cloud-4.0' into 211111_updatedepen…

c3c03cc

…dency_gzh

fix the logic of isValidURL()

adbd5b4

remove validation

3821895

stliu reviewed Nov 16, 2021

View reviewed changes

.../main/java/com/azure/spring/cloud/autoconfigure/cosmos/properties/AzureCosmosProperties.java Show resolved Hide resolved

Merge branch 'feature/azure-spring-cloud-4.0' into 211111_updatedepen…

e7020df

…dency_gzh

backwind1233 added 3 commits November 17, 2021 10:33

replace private method with a util class.

166a473

fix java doc

75192e9

add checkstyle-suppressions for URLValidator.java

69d8da2

backwind1233 requested a review from mssfang as a code owner November 17, 2021 05:16

backwind1233 merged commit 3570c2f into Azure:feature/azure-spring-cloud-4.0 Nov 17, 2021

backwind1233 deleted the 211111_updatedependency_gzh branch November 17, 2021 06:59

backwind1233 mentioned this pull request Nov 19, 2021

Review the artifact names and their dependencies before release #24722

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove validation dependency #25335

Remove validation dependency #25335

backwind1233 commented Nov 11, 2021 •

edited

Loading

backwind1233 commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

check-enforcer bot commented Nov 11, 2021

backwind1233 commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

saragluna commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

backwind1233 commented Nov 12, 2021

azure-pipelines bot commented Nov 12, 2021

chenrujun Nov 16, 2021

chenrujun Nov 16, 2021

chenrujun Nov 16, 2021

backwind1233 Nov 16, 2021

backwind1233 commented Nov 16, 2021

azure-pipelines bot commented Nov 16, 2021

saragluna commented Nov 16, 2021

azure-pipelines bot commented Nov 16, 2021

stliu Nov 16, 2021

stliu commented Nov 16, 2021

backwind1233 commented Nov 17, 2021

azure-pipelines bot commented Nov 17, 2021

azure-sdk commented Nov 17, 2021

backwind1233 commented Nov 17, 2021

backwind1233 commented Nov 17, 2021

azure-pipelines bot commented Nov 17, 2021

azure-pipelines bot commented Nov 17, 2021

Remove validation dependency #25335

Remove validation dependency #25335

Conversation

backwind1233 commented Nov 11, 2021 • edited Loading

backwind1233 commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

check-enforcer bot commented Nov 11, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

backwind1233 commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

saragluna commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

backwind1233 commented Nov 12, 2021

azure-pipelines bot commented Nov 12, 2021

chenrujun Nov 16, 2021

Choose a reason for hiding this comment

chenrujun Nov 16, 2021

Choose a reason for hiding this comment

chenrujun Nov 16, 2021

Choose a reason for hiding this comment

backwind1233 Nov 16, 2021

Choose a reason for hiding this comment

backwind1233 commented Nov 16, 2021

azure-pipelines bot commented Nov 16, 2021

saragluna commented Nov 16, 2021

azure-pipelines bot commented Nov 16, 2021

stliu Nov 16, 2021

Choose a reason for hiding this comment

stliu commented Nov 16, 2021

backwind1233 commented Nov 17, 2021

azure-pipelines bot commented Nov 17, 2021

azure-sdk commented Nov 17, 2021

backwind1233 commented Nov 17, 2021

backwind1233 commented Nov 17, 2021

azure-pipelines bot commented Nov 17, 2021

azure-pipelines bot commented Nov 17, 2021

backwind1233 commented Nov 11, 2021 •

edited

Loading