-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Keyvault client library #2613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de for method calls with long list of optional properties
…ing operation is handled implicitly by Azure core
…arameter, fix AdminDetails tag
…documentations for the WebKey types to reflect the accepted types
1) getObjests is changed to listObjects 2) Removed getObjectsNext as this is controlled by the library 3) Changes the request parameters for some update* operations to reflect mandatory and optional parameters. 4) Added tests for Async and some additional tests
…s in request classes.
Style Updates to README
Webkey 1.1 bug-fix
* Added a new POM file that encapsulates dependencies on all five modules * Made com.microsoft.azure:azure-client-authentication scope to test * Added some dependency management features * Modified dependencyManagement * Cleaned up webkey * Cleaned up cryptography * Cleaned up core * Added in used but undeclared dependencies * Removed dependency on commons-io, which appears unneeded * Cleaned up unused dependencies in extensions and fixed minor typographical problems * Added undeclared, but used, dependencies to extensions * Added some more package versions to the POMP * Extracted shared versions to parent pom * Added explicit dependencies to extensions and fixed some minor errors * Fixed some indentation differences * Fixed IT bug: * Updated all versions to 1.1.1 * fixed dependency version error * Updated integration-test path
1.1.1 Readme Updates
Merging 1.1.1 updates to master.
* Do not cache unversionned keys * Brihicks/fix gauva26.0 problems (Azure#63) * Fixed issues resulting from incompatibilities with Guava 26.0 * Updated versioning * Update pom.xml (Azure#66) * Versioning fix * Update pom.xml * Updated versions of all files 1.1.2 * Fixed test error (Azure#72) * Merging Dev to Master (Azure#69) * Do not cache unversionned keys * Brihicks/fix gauva26.0 problems (Azure#63) * Fixed issues resulting from incompatibilities with Guava 26.0 * Updated versioning * Update pom.xml (Azure#66) * Versioning fix * Update pom.xml * Updated versions of all files 1.1.2 * Fixed test error
Can one of the admins verify this patch? |
👍✨Ship It✨ |
bsiegel
approved these changes
Nov 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bsiegel
added a commit
that referenced
this pull request
Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.