Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt, compute, improve beginCreate javadoc and error message #26799

Merged
merged 3 commits into from
Jan 30, 2022
Merged

mgmt, compute, improve beginCreate javadoc and error message #26799

merged 3 commits into from
Jan 30, 2022

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jan 30, 2022 •
edited
Loading

Link #1910

Commit to review b0cae13
Rest is codegen.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weidongxu-microsoft weidongxu-microsoft added Mgmt This issue is related to a management-plane library. Mgmt - Track 2 labels Jan 30, 2022
@weidongxu-microsoft weidongxu-microsoft self-assigned this Jan 30, 2022
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review January 30, 2022 06:27
@weidongxu-microsoft weidongxu-microsoft merged commit d4e2e3b into Azure:main Jan 30, 2022
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_compute-improve-javadoc-and-error-message branch January 30, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaofeiCao XiaofeiCao XiaofeiCao approved these changes

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels
Mgmt - Track 2 Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weidongxu-microsoft @XiaofeiCao