Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unit test for updateDisposition closes link on timeout #28081

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Adding unit test for updateDisposition closes link on timeout #28081

merged 1 commit into from
Apr 7, 2022

Conversation

ki1729
Copy link
Contributor

@ki1729 ki1729 commented Apr 7, 2022

Description

Related to the change in PR - #22036
Added a unit test that verifies that link is closed when updateDisposition call fails with a timeout.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Service Bus label Apr 7, 2022
@ki1729 ki1729 self-assigned this Apr 7, 2022
@ki1729 ki1729 added this to the [2022] May milestone Apr 7, 2022
@azure-sdk
Copy link
Collaborator

API change check for com.azure:azure-messaging-servicebus

API changes are not detected in this pull request for com.azure:azure-messaging-servicebus

@ki1729 ki1729 merged commit ada9824 into Azure:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liukun-msft liukun-msft liukun-msft approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft

@ZejiaJiang ZejiaJiang Awaiting requested review from ZejiaJiang

Assignees

@ki1729 ki1729

Labels
Service Bus
Projects
None yet
Milestone
2022-05
Development

Successfully merging this pull request may close these issues.
3 participants
@ki1729 @azure-sdk @liukun-msft