Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt appservice, upgrade api-version 2022-03 #29796

Merged
merged 21 commits into from
Jul 25, 2022
Merged

mgmt appservice, upgrade api-version 2022-03 #29796

merged 21 commits into from
Jul 25, 2022

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Jul 5, 2022 •
edited
Loading

Description

Manual code for supporting deploymentStatus: 56622d1.
Live Tests in azure-resourcemanager-appservice passed.
Live Tests in samples with topLevelDomains failed.

fix https://github.com/Azure/sdk-release-request/issues/2960
relate #29677

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 5, 2022 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-appservice

@XiaofeiCao
Copy link
Contributor Author

They have a breaking change in topLevelDomains when running sample live tests. Need to investigate.

@XiaofeiCao XiaofeiCao added Do Not Merge Mgmt This issue is related to a management-plane library. Mgmt - Track 2 labels Jul 6, 2022
@XiaofeiCao
Copy link
Contributor Author

XiaofeiCao commented Jul 6, 2022 •
edited
Loading

Current WebApps_ListProductionSiteDeploymentStatuses returns empty list from service. Need to fix it before exposing convenience code.

@XiaofeiCao XiaofeiCao marked this pull request as ready for review July 6, 2022 13:51
@weidongxu-microsoft
Copy link
Member

PS: a pending PR on enum name Azure/azure-rest-api-specs#19654

@XiaofeiCao
Copy link
Contributor Author

Service has deployed topLevelDomains in their 2022-03.

Added 200 to syncFunctionTriggers response status code according to notes.

@weidongxu-microsoft
Copy link
Member

great, you are good to go.

@XiaofeiCao XiaofeiCao merged commit fd56dd2 into Azure:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees
No one assigned
Labels
Mgmt - Track 2 Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XiaofeiCao @azure-sdk @weidongxu-microsoft @bsndxz