Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt trafficmanager, regen code #30070

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

XiaofeiCao
Copy link
Contributor

Description

link #29991

manual code c45d55f :
Service needs id, name and type in EndpointInner for updating TrafficManagerProfile.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@XiaofeiCao XiaofeiCao self-assigned this Jul 21, 2022
@XiaofeiCao XiaofeiCao added Mgmt This issue is related to a management-plane library. Mgmt - Track 2 labels Jul 21, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-trafficmanager

@XiaofeiCao XiaofeiCao marked this pull request as ready for review July 21, 2022 03:43
@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jul 21, 2022

We might want to take a look on codegen later (not urgent).

Codegen should be able to find that id/name/type is not read-only (as in ProxyResource in azure-core-management), and generate them in the EndpointInner class.

This logic might be broken due to that Endpoint extends ProxyResource in swagger and then that extends Resource in swagger again (where these properties in Resources in not read-only).

The standard definition should be read-only https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v2/types.json#L9

@XiaofeiCao
Copy link
Contributor Author

Logged the issue here: Azure/autorest.java#1564

@XiaofeiCao XiaofeiCao merged commit be35021 into Azure:main Jul 21, 2022
@XiaofeiCao XiaofeiCao deleted the mgmt_regenerate_trafficmanager branch July 21, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt - Track 2 Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants