Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name change for callingserver to callautomation #30736

Merged
merged 6 commits into from
Sep 2, 2022

Conversation

juntuchen-msft
Copy link
Member

The current name refers to an internal team and not the product itself. After getting approval from marketing this month, we've been asked to eliminate references to the team name and center around the product name "Call Automation". Ideally this package should have never had the existing name.

This PR is for creating a new pipeline for callautomation; it duplicates callingserver with related names changed into callautomation. Once the new pipeline works correctly, next PR will head to remove the existing callingserver package and its pipeline.

@ghost ghost added the Communication label Sep 1, 2022
@juntuchen-msft juntuchen-msft self-assigned this Sep 1, 2022
@juntuchen-msft
Copy link
Member Author

juntuchen-msft commented Sep 1, 2022

This process is followed by the instruction provided in Azure SDK teams channel(https://teams.microsoft.com/l/message/19:5e673e41085f4a7eaaf20823b85b2b53@thread.skype/1661192131702?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1661182002456&teamName=Azure%20SDK&channelName=Language%20-%20Java&createdTime=1661192131702)

"If you don't care about losing history of the existing pipeline, I think the simplest option is:

  1. Create a PR to move your SDK and ci.yml
  2. Follow the steps at https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/117/Setting-up-a-new-Unified-Pipeline to create a new pipeline
  3. Submit a request in the "Engineering System" channel for us to delete the old pipeline
  4. If you want to keep the history of the existing pipeline, then EngSys will need to edit the existing pipeline instead of steps 2 and 3 above."

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-common

@juntuchen-msft juntuchen-msft marked this pull request as ready for review September 2, 2022 20:13
@juntuchen-msft juntuchen-msft merged commit 36e3917 into main Sep 2, 2022
@juntuchen-msft juntuchen-msft deleted the juntuchen/namechange branch September 2, 2022 20:36
vcolin7 pushed a commit to vcolin7/azure-sdk-for-java that referenced this pull request Sep 9, 2022
Changing name of callingserver to callautomation. This change will be done by the following steps:
1. Duplicate the code with new package name(sdk/communication/azure-communication-callautomation)  [Done in this step]
2. Based on the new code, a new pipeline will be automatically created. Verify the pipeline and do sanity test on the generated artifact. Make sure everything works perfectly under the new package name.  [Will be done by merging this PR]
3. Merge a PR to remove sdk/communication/azure-communication-callingserver
4. Submit request to Engineering System channel in Teams for removing the old pipeline(callingserver pipeline)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants