mgmt, upgrade compute (Gallery) #31322
Conversation
weidongxu-microsoft
added
the
Mgmt
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
hold on, waiting for explanations from service https://github.com/Azure/sdk-release-request/issues/3235 on API change and potential behavior change. |
weidongxu-microsoft
requested review from
mssfang,
JonathanGiles,
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
| - Supported `copyCompletionPercent` and `copyCompletionError` method in `Snapshot` for retrieving `CopyStart` progress. | ||
| - Supported `copyCompletionPercent` and `copyCompletionError` method in `Snapshot` for retrieving `CopyStart` progress. |
There was a problem hiding this comment.
These seem to be duplicate.
There was a problem hiding this comment.
thanks. caused by conflict resolve. solved.
| - Supported `withTrustedLaunch`, `withSecureBoot` and `withVTpm` methods in `VirtualMachine`. | ||
| - Supported `UBUNTU_SERVER_18_04_LTS_GEN2`, `UBUNTU_SERVER_20_04_LTS` and `UBUNTU_SERVER_20_04_LTS_GEN2` in `KnownLinuxVirtualMachineImage`. | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| - Property `uri` removed from `GalleryArtifactVersionSource`. This property was non-functional. |
There was a problem hiding this comment.
nit, this may affect customer calling serviceClient here:
#31860 (comment)
though I doubt their code ever run. I will provide them with an example with convenience code.
There was a problem hiding this comment.
Got it. Thought about whether to rename the new GalleryDiskImageSource to previous GalleryArtifactVersionSource (as it got uri but one more property).
And it might get less breaks.
However, this could make the model definition in Java too diverged from what intended by service.
Live test passes.
There are some minor breaking changes, but user on convenience API likely won't be affected.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines