Enhancing CosmosTemplate to Support Multi-Tenancy at a Container Level #33400
Conversation
…level Spring multitenant container level
TheovanKraay
requested review from
kushagraThapar,
FabianMeiswinkel,
backwind1233,
chenrujun,
hui1110,
Netyyyy,
saragluna,
stliu,
yiliuTo,
xinlian12,
moarychan,
aayush3011,
simorenoh,
fangjian0423,
jeet1995 and
Pilchie
as code owners
ghost
added
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| * @param cosmosAsyncClient cosmosAsyncClient | ||
| * @param databaseName databaseName | ||
| */ | ||
| public MultiTenantContainerCosmosFactory(CosmosAsyncClient cosmosAsyncClient, String databaseName) { |
There was a problem hiding this comment.
just curious, why we do not have an constructor accepting containerName? and also in Spring, we do not really use setter pattern?
There was a problem hiding this comment.
By default, container name is taken from either entity name, or containerName in @container within entity if defined. So it need not be passed to the constructor by default (but we add the setter/getter here so it can be overridden and called polymorphically in the case of multi-tenant scenario). For databaseName, this has to be passed in, as that has to be defined in config. For getter/setter, yes we should, but these are just sample classes to facilitate the unit tests, and will only be used by them, they are not part of the API (user would create their own, and we'll have examples for that in samples repo).
Description
This PR adds support for multi-tenancy at a container level via the CosmosFactory. There is a test case added which shows how the user can extend CosmosFactory and use overrideContainerName() in order to dynamically set the container being used by CosmosTemplate and repositories when making calls. Integration test coverage was added for this new feature. Reactive tests are also added for container and database level multitenancy (see PR #32516).
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines